Skip to content

Remove duplicate paths in FileAccessTree#123776

Merged
prdoyle merged 5 commits intoelastic:mainfrom
jdconrad:prunedups
Mar 3, 2025
Merged

Remove duplicate paths in FileAccessTree#123776
prdoyle merged 5 commits intoelastic:mainfrom
jdconrad:prunedups

Conversation

@jdconrad
Copy link
Copy Markdown
Contributor

This updates our pruning method to remove duplicate paths in addition to parent/child paths.

@jdconrad jdconrad added >non-issue auto-backport Automatically create backport pull requests when merged test-entitlements v8.18.1 v8.19.0 v9.0.1 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels Feb 28, 2025
@jdconrad jdconrad requested a review from a team as a code owner February 28, 2025 23:10
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 28, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@jdconrad
Copy link
Copy Markdown
Contributor Author

jdconrad commented Mar 1, 2025

@elasticmachine run elasticsearch-ci/part-2

@prdoyle prdoyle self-assigned this Mar 3, 2025
@prdoyle prdoyle enabled auto-merge (squash) March 3, 2025 20:11
@prdoyle prdoyle merged commit 3e2597f into elastic:main Mar 3, 2025
22 checks passed
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💔 Backport failed

Status Branch Result
8.18 Commit could not be cherrypicked due to conflicts
8.x Commit could not be cherrypicked due to conflicts
9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 123776

prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Mar 3, 2025
Co-authored-by: Lorenzo Dematté <lorenzo.dematte@elastic.co>
Co-authored-by: Patrick Doyle <810052+prdoyle@users.noreply.github.com>
prdoyle added a commit that referenced this pull request Mar 7, 2025
…123776 and #124023) (#123924)

* remove duplicate paths in FileAccessTree (#123776)

Co-authored-by: Lorenzo Dematté <lorenzo.dematte@elastic.co>
Co-authored-by: Patrick Doyle <810052+prdoyle@users.noreply.github.com>

* Remove duplicate exclusive paths (#124023)

* Remove duplicate exclusive paths

* Normalize paths in tests to support Windows

* Remove withMode

---------

Co-authored-by: Jack Conradson <osjdconrad@gmail.com>
Co-authored-by: Lorenzo Dematté <lorenzo.dematte@elastic.co>
prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Mar 7, 2025
…lastic#123776 and elastic#124023) (elastic#123924)

* remove duplicate paths in FileAccessTree (elastic#123776)

Co-authored-by: Lorenzo Dematté <lorenzo.dematte@elastic.co>
Co-authored-by: Patrick Doyle <810052+prdoyle@users.noreply.github.com>

* Remove duplicate exclusive paths (elastic#124023)

* Remove duplicate exclusive paths

* Normalize paths in tests to support Windows

* Remove withMode

---------

Co-authored-by: Jack Conradson <osjdconrad@gmail.com>
Co-authored-by: Lorenzo Dematté <lorenzo.dematte@elastic.co>
prdoyle added a commit to prdoyle/elasticsearch that referenced this pull request Mar 7, 2025
…lastic#123776 and elastic#124023) (elastic#123924)

* remove duplicate paths in FileAccessTree (elastic#123776)

Co-authored-by: Lorenzo Dematté <lorenzo.dematte@elastic.co>
Co-authored-by: Patrick Doyle <810052+prdoyle@users.noreply.github.com>

* Remove duplicate exclusive paths (elastic#124023)

* Remove duplicate exclusive paths

* Normalize paths in tests to support Windows

* Remove withMode

---------

Co-authored-by: Jack Conradson <osjdconrad@gmail.com>
Co-authored-by: Lorenzo Dematté <lorenzo.dematte@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Mar 8, 2025
…123776 and #124023) (#123924) (#124331)

* remove duplicate paths in FileAccessTree (#123776)




* Remove duplicate exclusive paths (#124023)

* Remove duplicate exclusive paths

* Normalize paths in tests to support Windows

* Remove withMode

---------

Co-authored-by: Jack Conradson <osjdconrad@gmail.com>
Co-authored-by: Lorenzo Dematté <lorenzo.dematte@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Mar 9, 2025
…123776 and #124023) (#123924) (#124332)

* remove duplicate paths in FileAccessTree (#123776)




* Remove duplicate exclusive paths (#124023)

* Remove duplicate exclusive paths

* Normalize paths in tests to support Windows

* Remove withMode

---------

Co-authored-by: Jack Conradson <osjdconrad@gmail.com>
Co-authored-by: Lorenzo Dematté <lorenzo.dematte@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025
Co-authored-by: Lorenzo Dematté <lorenzo.dematte@elastic.co>
Co-authored-by: Patrick Doyle <810052+prdoyle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure >non-issue Team:Core/Infra Meta label for core/infra team v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants