Skip to content

ES|QL: disable mixed cluster CSV tests that require source field mapping#122607

Merged
luigidellaquila merged 1 commit intoelastic:mainfrom
luigidellaquila:esql/fix_mixed_cluster_tests
Feb 14, 2025
Merged

ES|QL: disable mixed cluster CSV tests that require source field mapping#122607
luigidellaquila merged 1 commit intoelastic:mainfrom
luigidellaquila:esql/fix_mixed_cluster_tests

Conversation

@luigidellaquila
Copy link
Copy Markdown
Member

Mixed cluster tests fail in serverless, as source mapping is not allowed.
All the other multi-node CSV tests have these tests disabled already, see single_node and multi_node EsqlSpecIT.
We are doing the same for Mixed cluster

@luigidellaquila luigidellaquila added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.0.1 v9.1.0 test-update-serverless labels Feb 14, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 14, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💔 Backport failed

Status Branch Result
9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 122607

@luigidellaquila
Copy link
Copy Markdown
Member Author

luigidellaquila commented Feb 14, 2025

Oh, so the original PR was not backported to 9.0...

elasticsearchmachine pushed a commit that referenced this pull request Feb 18, 2025
#121261, #122607) (#122805)

* ESQL: Support for _index metadata field in CsvTests (#121261)

* ESQL: Support for _index metadata field in CsvTests

* Extract INDEX constant to MetadataAttribute

* Add comment on capability

* ESQL: Initial support for unmapped fields (#119886)

This PR adds initial support for unmapped fields, using the INSIST clause. For starters, this unmapped fields without a cast.
Note that the INSIST keyword is potentially a placeholder, as the method of defining an unmapped field might change in the future, e.g., use a special magic function. As this is currently under development, the actual syntax is INSIST_🐔.

First stage of #120072.

Specifically, the following features are implemented in this PR:

* Support for INSIST keyword without a cast. In particular, if the type being INSISTed upon is mapped to anything other than KEYWORD, it will result in an InvalidMappedField. There is no support for union type resolution on top of INSIST. Future PRs will handle these conflicts. There is support for multiple parameters, or INSIST on top of INSIST which is equivalent.
* Enforcing that INSIST must always be on top of a FROM or another INSIST. While this may change in the future, e.g., handling cases like `FROM foo | EVAL x = 1 | INSIST bar` will not be done in this PR, as it makes handling INSIST too complicated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged backport pending Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests test-update-serverless v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants