RegexpQueryParser takes a String as value like its Builder#12200
Closed
alexksikes wants to merge 2 commits intoelastic:masterfrom
Closed
RegexpQueryParser takes a String as value like its Builder#12200alexksikes wants to merge 2 commits intoelastic:masterfrom
alexksikes wants to merge 2 commits intoelastic:masterfrom
Conversation
Contributor
|
don't we want to change the mappers as well to accept a String instead of an Object? |
9d49b75 to
bda8092
Compare
Contributor
Author
|
@javanna Thanks for the review. I changed the mapper as well. |
Contributor
There was a problem hiding this comment.
not sure whether we want to use text() or textOrNull() here
Contributor
There was a problem hiding this comment.
Alex's comment on the prefix query that we need to check for null anyway and can have a better error message this way makes sense to me
Contributor
|
looks good, @jpountz can you please have a look too? I had a question above ;) |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #11896