Skip to content

Run template simulation actions on local node#120038

Merged
nielsbauman merged 2 commits intoelastic:mainfrom
nielsbauman:local-simulate
Jan 14, 2025
Merged

Run template simulation actions on local node#120038
nielsbauman merged 2 commits intoelastic:mainfrom
nielsbauman:local-simulate

Conversation

@nielsbauman
Copy link
Copy Markdown
Contributor

@nielsbauman nielsbauman commented Jan 13, 2025

The actions TransportSimulateTemplateAction and
TransportSimulateIndexTemplateAction solely need the cluster state, they can run on any node. Additionally, they need to be cancellable to avoid doing unnecessary work after a client failure or timeout.

As a drive-by, this removes more usages of the trappy default master node timeout.

Relates #101805
Relates #107984

The actions `TransportSimulateTemplateAction` and
`TransportSimulateIndexTemplateAction` solely need the cluster state,
they can run on any node. Additionally, they need to be cancellable
to avoid doing unnecessary work after a client failure or timeout.

As a drive-by, this removes another usage of the trappy default master
node timeout.
@nielsbauman nielsbauman added >enhancement :Distributed/Ingest Node Execution or management of Ingest Pipelines Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v9.0.0 labels Jan 13, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @nielsbauman, I've created a changelog YAML for you.

Copy link
Copy Markdown
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Niels!

@nielsbauman nielsbauman merged commit 27a9c4d into elastic:main Jan 14, 2025
@nielsbauman nielsbauman deleted the local-simulate branch January 14, 2025 02:41
martijnvg pushed a commit to martijnvg/elasticsearch that referenced this pull request Jan 14, 2025
The actions `TransportSimulateTemplateAction` and
`TransportSimulateIndexTemplateAction` solely need the cluster state,
they can run on any node. Additionally, they need to be cancellable
to avoid doing unnecessary work after a client failure or timeout.

As a drive-by, this removes more usages of the trappy default master
node timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Ingest Node Execution or management of Ingest Pipelines >enhancement Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants