Disable TO_UPPER(null) BWC tests prior to 8.17#119213
Merged
elasticsearchmachine merged 1 commit intoelastic:mainfrom Dec 23, 2024
Merged
Disable TO_UPPER(null) BWC tests prior to 8.17#119213elasticsearchmachine merged 1 commit intoelastic:mainfrom
TO_UPPER(null) BWC tests prior to 8.17#119213elasticsearchmachine merged 1 commit intoelastic:mainfrom
Conversation
TO_UPPER/TO_LOWER incorrectly returned child's type, instead of KEYWORD. So a test like `TO_UPPER(null) == "..."` failed on type mismatch.
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Dec 23, 2024
TO_UPPER/TO_LOWER resolution incorrectly returned child's type (that could also be `null`, type `NULL`), instead of KEYWORD/TEXT. So a test like `TO_UPPER(null) == "..."` fails on type mismatch. This was fixed collaterally by elastic#114334 (8.17.0) Also, correct some of the tests skipping (that had however no impact, due to testing range). (cherry picked from commit edb3818)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 23, 2024
* ESQL: Rewrite TO_UPPER/TO_LOWER comparisons (#118870) This adds an optimization rule to rewrite TO_UPPER/TO_LOWER comparisons against a string into an InsensitiveEquals comparison. The rewrite can also result right away into a TRUE/FALSE, in case the string doesn't match the caseness of the function. This also allows later pushing down the predicate to lucene as a case-insensitive term-query. Fixes #118304. * Disable `TO_UPPER(null)`-tests prior to 8.17 (#119213) TO_UPPER/TO_LOWER resolution incorrectly returned child's type (that could also be `null`, type `NULL`), instead of KEYWORD/TEXT. So a test like `TO_UPPER(null) == "..."` fails on type mismatch. This was fixed collaterally by #114334 (8.17.0) Also, correct some of the tests skipping (that had however no impact, due to testing range). (cherry picked from commit edb3818)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TO_UPPER/TO_LOWER resolution incorrectly returned child's type (that could also be
null, typeNULL), instead of KEYWORD/TEXT. So a test likeTO_UPPER(null) == "..."fails on type mismatch.This was fixed collaterally by #114334 (8.17.0)
Also, correct some of the tests skipping (that had however no impact, due to testing range).