Fix reconstituting version string from components#117213
Merged
smalyshev merged 9 commits intoelastic:mainfrom Dec 4, 2024
Merged
Fix reconstituting version string from components#117213smalyshev merged 9 commits intoelastic:mainfrom
smalyshev merged 9 commits intoelastic:mainfrom
Conversation
Collaborator
|
Hi @smalyshev, I've created a changelog YAML for you. |
bcaa35f to
e6461b6
Compare
e6461b6 to
7e1953c
Compare
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @smalyshev, I've created a changelog YAML for you. |
Contributor
Author
|
@elasticmachine update branch |
joegallo
approved these changes
Dec 3, 2024
Contributor
joegallo
left a comment
There was a problem hiding this comment.
LGTM! I added some commits as a form of review. There was a build failure for the docs, which I don't understand -- I'm hoping it'll just pass with the next round of CI and we won't have to look into it.
This was referenced Dec 4, 2024
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Dec 4, 2024
* Fix reconstituting version string from components Co-authored-by: Joe Gallo <joegallo@gmail.com> (cherry picked from commit 28eda97) # Conflicts: # modules/ingest-user-agent/src/main/java/org/elasticsearch/ingest/useragent/UserAgentProcessor.java # modules/ingest-user-agent/src/test/java/org/elasticsearch/ingest/useragent/UserAgentProcessorTests.java
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Dec 4, 2024
* Fix reconstituting version string from components Co-authored-by: Joe Gallo <joegallo@gmail.com> (cherry picked from commit 28eda97) # Conflicts: # modules/ingest-user-agent/src/main/java/org/elasticsearch/ingest/useragent/UserAgentProcessor.java # modules/ingest-user-agent/src/test/java/org/elasticsearch/ingest/useragent/UserAgentProcessorTests.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Dec 4, 2024
* Fix reconstituting version string from components Co-authored-by: Joe Gallo <joegallo@gmail.com> (cherry picked from commit 28eda97) # Conflicts: # modules/ingest-user-agent/src/main/java/org/elasticsearch/ingest/useragent/UserAgentProcessor.java # modules/ingest-user-agent/src/test/java/org/elasticsearch/ingest/useragent/UserAgentProcessorTests.java
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Dec 4, 2024
* Fix reconstituting version string from components Co-authored-by: Joe Gallo <joegallo@gmail.com> (cherry picked from commit 28eda97)
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Dec 4, 2024
* Fix reconstituting version string from components Co-authored-by: Joe Gallo <joegallo@gmail.com> (cherry picked from commit 28eda97)
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Dec 4, 2024
* Fix reconstituting version string from components Co-authored-by: Joe Gallo <joegallo@gmail.com> (cherry picked from commit 28eda97)
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Dec 4, 2024
* Fix reconstituting version string from components Co-authored-by: Joe Gallo <joegallo@gmail.com> (cherry picked from commit 28eda97)
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Dec 4, 2024
* Fix reconstituting version string from components Co-authored-by: Joe Gallo <joegallo@gmail.com> (cherry picked from commit 28eda97)
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Dec 4, 2024
* Fix reconstituting version string from components Co-authored-by: Joe Gallo <joegallo@gmail.com> (cherry picked from commit 28eda97)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 4, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 4, 2024
smalyshev
added a commit
that referenced
this pull request
Dec 4, 2024
Oddly
added a commit
to Oddly/integrations
that referenced
this pull request
Mar 26, 2026
The user_agent ingest processor in ES versions before 8.16.2 produces version strings with a trailing dot for certain user agents like Firefox/128.0, which causes pipeline test failures. This was fixed in elastic/elasticsearch#117213 and shipped in 8.16.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes how
UserAgentProcessor.javareconsititutes versions. Some patterns may generate empty strings for version components, which will lead to incorrect versions having dangling dots, etc. This patch fixes the issue.Fixes #116950