Remove test disabling field names#116937
Merged
thecoop merged 1 commit intoelastic:mainfrom Nov 19, 2024
Merged
Conversation
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
javanna
approved these changes
Nov 18, 2024
Contributor
javanna
left a comment
There was a problem hiding this comment.
For posterity: this PR does not remove the functionality that allows to disable _field_names, but rather the related testing only.
We will likely need to keep the handling of that parameter in the mappings code for archive indices.
Member
Author
|
@javanna does this then need to be replaced with another test, or is that something to be looked at at a later point? |
Contributor
|
@thecoop to be determined at a later point :) perhaps some specific test for the scenario where older indices have |
Member
Author
|
OK, I'll leave that for the search team to look at separately |
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 20, 2024
The test is conditional on the old version being pre-v8, which is never true on main now
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
The test is conditional on the old version being pre-v8, which is never true on main now
cbuescher
added a commit
to cbuescher/elasticsearch
that referenced
this pull request
Dec 18, 2024
This reverts commit 0db51d5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove the associated historical feature