[ESQL] test date nanos union type#116265
Merged
not-napoleon merged 9 commits intoelastic:mainfrom Nov 11, 2024
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Member
Author
|
So I discovered a bunch of these tests weren't running locally. I've fixed most of them, but there's still one failing for me that requires deeper investigation. |
Member
Author
|
The remaining test failure is due to #116346, I think. |
Member
Author
|
Should be fixed now. Let's see what CI thinks. |
astefan
approved these changes
Nov 11, 2024
| ; | ||
|
|
||
| @timestamp:date_nanos | client_ip:ip | event_duration:long | message:keyword | ||
| 2023-10-23T13:55:01.543Z | 172.21.3.15 | 1756467 | Connected to 10.1.0.1 |
Contributor
There was a problem hiding this comment.
I was expecting here a bunch if zeros after the decimal dot.
I see them here and it seems right.
Member
Author
There was a problem hiding this comment.
This happens because the date nanos expected values parsing uses the ISO_DATE_WITH_NANOS saved format, which specifies .appendFraction(NANO_OF_SECOND, 3, 9, true). The 3, 9 there specifies a minimum "width" (i.e. number of digits) of 3 and a maximum of 9, so either format would be acceptable.
That said, it's easy enough to add in the zeros, I'll push that up in a moment. While I was looking at it, I noticed that when I wrote the value parsing logic, I missed an opportunity to use the library function for it, so I've replaced my math with that. This gets us a little extra error checking for expected values.
Member
Author
|
@elasticmachine test this please |
Member
Author
|
@elasticmachine update branch |
Collaborator
💚 Backport successful
|
not-napoleon
added a commit
to not-napoleon/elasticsearch
that referenced
this pull request
Nov 11, 2024
Resolves elastic#112885 This PR adds a bunch of basic testing for using TO_DATE_NANOS as a union type. It also tests the TO_DATETIME union type for casting date nanos. There are still some cases that aren't covered here, mostly because we haven't finished adding date nanos support to all the relevant functions. I expect we'll add in those cases as we add functions support. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jozala
pushed a commit
that referenced
this pull request
Nov 13, 2024
Resolves #112885 This PR adds a bunch of basic testing for using TO_DATE_NANOS as a union type. It also tests the TO_DATETIME union type for casting date nanos. There are still some cases that aren't covered here, mostly because we haven't finished adding date nanos support to all the relevant functions. I expect we'll add in those cases as we add functions support. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Nov 14, 2024
Resolves elastic#112885 This PR adds a bunch of basic testing for using TO_DATE_NANOS as a union type. It also tests the TO_DATETIME union type for casting date nanos. There are still some cases that aren't covered here, mostly because we haven't finished adding date nanos support to all the relevant functions. I expect we'll add in those cases as we add functions support. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
not-napoleon
added a commit
that referenced
this pull request
Nov 19, 2024
* [ESQL] test date nanos union type (#116265) Resolves #112885 This PR adds a bunch of basic testing for using TO_DATE_NANOS as a union type. It also tests the TO_DATETIME union type for casting date nanos. There are still some cases that aren't covered here, mostly because we haven't finished adding date nanos support to all the relevant functions. I expect we'll add in those cases as we add functions support. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * add capability check * add capability check --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Resolves elastic#112885 This PR adds a bunch of basic testing for using TO_DATE_NANOS as a union type. It also tests the TO_DATETIME union type for casting date nanos. There are still some cases that aren't covered here, mostly because we haven't finished adding date nanos support to all the relevant functions. I expect we'll add in those cases as we add functions support. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #112885
This PR adds a bunch of basic testing for using
TO_DATE_NANOSas a union type. It also tests theTO_DATETIMEunion type for casting date nanos. There are still some cases that aren't covered here, mostly because we haven't finished adding date nanos support to all the relevant functions. I expect we'll add in those cases as we add functions support.