Synonyms test fix - number of shards#116224
Merged
carlosdelest merged 4 commits intoelastic:mainfrom Nov 6, 2024
Merged
Conversation
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
kingherc
reviewed
Nov 5, 2024
Contributor
kingherc
left a comment
There was a problem hiding this comment.
LGTM with respect to number of replicas. But i'll better let a Search member approve.
carlosdelest
added a commit
to carlosdelest/elasticsearch
that referenced
this pull request
Nov 11, 2024
(cherry picked from commit e594072)
carlosdelest
added a commit
that referenced
this pull request
Nov 11, 2024
jozala
pushed a commit
that referenced
this pull request
Nov 13, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some synonyms tests were failing on serverless because the number of replicas can't be established there.
Changed tests so replicas are not established, and change checks to not depend on number of replicas directly.