Fix release tests for semantic_text#116202
Merged
ioanatia merged 1 commit intoelastic:mainfrom Nov 5, 2024
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
ioanatia
added a commit
to ioanatia/elasticsearch
that referenced
this pull request
Nov 5, 2024
ioanatia
added a commit
that referenced
this pull request
Nov 5, 2024
* semantic_text as string type in ES|QL - support for functions and operators (#115243) * fix tests * Add CSV tests * Add function tests * Refactor tests * spotless * Use DataType.stringTypes() where possible * Add tests for conditional functions and expressions * Fix tests after merge * Reorder semantic_text evaluators and tests * Re-ordered two more places for SEMANTIC_TEXT after TEXT --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Craig Taverner <craig@amanzi.com> * Fix release tests for semantic_text (#116202) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Craig Taverner <craig@amanzi.com>
jozala
pushed a commit
that referenced
this pull request
Nov 13, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #116177
I initially thought I need this check too in
DataType.isString, but it is not needed. Having it underDataType.UNDER_CONSTRUCTIONas we have fordate_nanosshould suffice.semantic_textremains unsupported in non snapshot builds (just to be sure I checked by running Elasticsearch with-Dbuild.snapshot=false). The representation ofsemantic_textfields is not returned andsemantic_textfields cannot be referenced as function/operator arguments for non snapshot builds.