Skip to content

ES|QL Add full-text search to the functions docs page#116024

Merged
ChrisHegarty merged 4 commits intoelastic:mainfrom
ChrisHegarty:esql_search_func_docs
Nov 1, 2024
Merged

ES|QL Add full-text search to the functions docs page#116024
ChrisHegarty merged 4 commits intoelastic:mainfrom
ChrisHegarty:esql_search_func_docs

Conversation

@ChrisHegarty
Copy link
Copy Markdown
Contributor

@ChrisHegarty ChrisHegarty commented Oct 31, 2024 •
edited
Loading

Now that the match and qstr functions are Tech Previewing we should add them to the top-level functions doc page.

Screenshot 2024-11-01 at 11 03 02

@ChrisHegarty ChrisHegarty added >docs General docs changes Team:Search Meta label for search team :Search Relevance/Search Catch all for Search Relevance v9.0.0 v8.17.0 labels Oct 31, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 31, 2024

Documentation preview:

@ChrisHegarty ChrisHegarty mentioned this pull request Oct 31, 2024
Closed
14 tasks
@ChrisHegarty ChrisHegarty changed the title ES|QL Add full-text search to top-level function docs ES|QL Add full-text search to the function docs page Oct 31, 2024
@ChrisHegarty ChrisHegarty marked this pull request as ready for review October 31, 2024 16:02
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch and removed Team:Search Meta label for search team labels Oct 31, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Oct 31, 2024

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Oct 31, 2024

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@ChrisHegarty ChrisHegarty changed the title ES|QL Add full-text search to the function docs page ES|QL Add full-text search to the functions docs page Oct 31, 2024
@ChrisHegarty
Copy link
Copy Markdown
Contributor Author

ChrisHegarty commented Oct 31, 2024 •
edited
Loading

we'll need to update the limitations page too:

https://github.com/elastic/elasticsearch/blob/main/docs/reference/esql/esql-limitations.asciidoc#full-text-search-is-not-supported

Done.

afoucret
afoucret approved these changes Nov 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@afoucret afoucret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall OK but I would add a preview flag for these function as done for others tech preview functions:

Capture d’écran 2024-11-01 à 12 00 22

@ChrisHegarty
Copy link
Copy Markdown
Contributor Author

ChrisHegarty commented Nov 1, 2024

Overall OK but I would add a preview flag for these function as done for others tech preview functions:

Thanks. Done.

Screenshot 2024-11-01 at 11 03 12

ioanatia
ioanatia reviewed Nov 1, 2024
View reviewed changes
docs/reference/esql/esql-limitations.asciidoc
[discrete]
[[esql-limitations-full-text-search]]
=== Full-text search is not supported
=== Full-text search
Copy link
Copy Markdown
Member

@ioanatia ioanatia Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉 !

ioanatia
ioanatia approved these changes Nov 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ioanatia ioanatia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@afoucret looks like we have a preview flag already?

Screenshot 2024-11-01 at 12 05 08

and in function docs we have a disclaimer
Screenshot 2024-11-01 at 12 05 35

unless you meant something else?

EDIT: Chris is too fast 😄

@ChrisHegarty
Copy link
Copy Markdown
Contributor Author

ChrisHegarty commented Nov 1, 2024

@afoucret looks like we have a preview flag already?

It's there now. @afoucret may have been looking at a slightly outdated preview or something. :-)

@afoucret
Copy link
Copy Markdown
Contributor

afoucret commented Nov 1, 2024

My bad, I don't know why I thought it was missing

@ChrisHegarty ChrisHegarty merged commit 2275894 into elastic:main Nov 1, 2024
@ChrisHegarty ChrisHegarty deleted the esql_search_func_docs branch November 1, 2024 12:05
ChrisHegarty added a commit that referenced this pull request Nov 1, 2024
@ChrisHegarty @craigtaverner
ES|QL Add full-text search to the functions docs page (#116024)
78fc557 
Now that the match and qstr functions are Tech Previewing, we should add them to the top-level functions doc page.

Co-authored-by: Craig Taverner <craig@amanzi.com>
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
@ChrisHegarty @craigtaverner @jfreden
ES|QL Add full-text search to the functions docs page (elastic#116024)
15b7a49 
Now that the match and qstr functions are Tech Previewing, we should add them to the top-level functions doc page.

Co-authored-by: Craig Taverner <craig@amanzi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ioanatia ioanatia ioanatia approved these changes

@bpintea bpintea Awaiting requested review from bpintea

@craigtaverner craigtaverner Awaiting requested review from craigtaverner

+1 more reviewer

@afoucret afoucret afoucret approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

>docs General docs changes :Search Relevance/Search Catch all for Search Relevance Team:Docs Meta label for docs team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.17.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ChrisHegarty @elasticsearchmachine @afoucret @ioanatia @craigtaverner