Skip to content

ESQL: Fix grammar changes around per agg filtering#114848

Merged
costin merged 2 commits intoelastic:mainfrom
costin:esql/filter-per-agg-grammar
Oct 15, 2024
Merged

ESQL: Fix grammar changes around per agg filtering#114848
costin merged 2 commits intoelastic:mainfrom
costin:esql/filter-per-agg-grammar

Conversation

@costin
Copy link
Copy Markdown
Member

@costin costin commented Oct 15, 2024

Remove dev flag left in grammar for agg filtering
Related to #113735

Remove dev flag left in grammar for agg filtering
Related to elastic#113735
@costin costin added >bug auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v8.16.0 v9.0.0 labels Oct 15, 2024
@costin costin requested a review from fang-xing-esql October 15, 2024 15:54
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @costin, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Oct 15, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Copy Markdown
Member

@fang-xing-esql fang-xing-esql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@costin costin merged commit 5e59ab5 into elastic:main Oct 15, 2024
@costin costin deleted the esql/filter-per-agg-grammar branch October 15, 2024 17:13
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 114848

costin added a commit to costin/elasticsearch that referenced this pull request Oct 15, 2024
Remove dev flag left in grammar for agg filtering
Related to elastic#113735

(cherry picked from commit 5e59ab5)
elasticsearchmachine pushed a commit that referenced this pull request Oct 15, 2024
Remove dev flag left in grammar for agg filtering
Related to #113735

(cherry picked from commit 5e59ab5)
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
Remove dev flag left in grammar for agg filtering
Related to elastic#113735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged backport pending >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants