Skip to content

[test] Don't test any 7.x snapshots in testLogicallyEquivalentSnapshotIsUsedEvenIfFilesAreDifferent#114821

Merged
arteam merged 5 commits intoelastic:mainfrom
arteam:update-testLogicallyEquivalentSnapshotIsUsedEvenIfFilesAreDifferent
Oct 24, 2024
Merged

[test] Don't test any 7.x snapshots in testLogicallyEquivalentSnapshotIsUsedEvenIfFilesAreDifferent#114821
arteam merged 5 commits intoelastic:mainfrom
arteam:update-testLogicallyEquivalentSnapshotIsUsedEvenIfFilesAreDifferent

Conversation

@arteam
Copy link
Copy Markdown
Contributor

@arteam arteam commented Oct 15, 2024

Don't test any 7.x snapshots, keep using any 8,x compatible snapshot and Lucene version.

Originally added in 8.0 (#77420) for testing peer recoveries using snapshots.

…erent for 8.x

We don't test any 7.x snapshots, keep using any 8,x compatible snapshot and Lucene version.
@arteam arteam added :Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. test-release Trigger CI checks against release build >test Issues or PRs that are addressing/adding tests and removed test-release Trigger CI checks against release build labels Oct 15, 2024
…quivalentSnapshotIsUsedEvenIfFilesAreDifferent
@arteam arteam changed the title [test] Update testLogicallyEquivalentSnapshotIsUsedEvenIfFilesAreDifferent for 9.x [test] Update SnapshotsRecoveryPlannerServiceTests#testLogicallyEquivalentSnapshotIsUsedEvenIfFilesAreDifferent for 9.x Oct 16, 2024
@arteam arteam marked this pull request as ready for review October 16, 2024 08:04
@arteam arteam requested a review from DaveCTurner October 16, 2024 08:04
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team. label Oct 16, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@arteam arteam requested a review from ywangd October 23, 2024 13:51
@arteam arteam changed the title [test] Update SnapshotsRecoveryPlannerServiceTests#testLogicallyEquivalentSnapshotIsUsedEvenIfFilesAreDifferent for 9.x [test] Don't test any 7.x snapshots in testLogicallyEquivalentSnapshotIsUsedEvenIfFilesAreDifferent Oct 23, 2024
Copy link
Copy Markdown
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion

arteam and others added 2 commits October 24, 2024 10:26
…ticsearch/xpack/snapshotbasedrecoveries/recovery/plan/SnapshotsRecoveryPlannerServiceTests.java

Co-authored-by: Yang Wang <ywangd@gmail.com>
@arteam
Copy link
Copy Markdown
Contributor Author

arteam commented Oct 24, 2024

@elasticmachine update branch

@arteam arteam added auto-merge auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) and removed auto-merge auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Oct 24, 2024
@arteam arteam merged commit d8a3fc2 into elastic:main Oct 24, 2024
@arteam arteam deleted the update-testLogicallyEquivalentSnapshotIsUsedEvenIfFilesAreDifferent branch October 24, 2024 14:59
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
…otIsUsedEvenIfFilesAreDifferent` (elastic#114821)

Don't test any 7.x snapshots, keep using any 8,x compatible snapshot and Lucene version.

Originally added in 8.0 (elastic#77420) for testing peer recoveries using snapshots.

Co-authored-by: Yang Wang <ywangd@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
…otIsUsedEvenIfFilesAreDifferent` (elastic#114821)

Don't test any 7.x snapshots, keep using any 8,x compatible snapshot and Lucene version.

Originally added in 8.0 (elastic#77420) for testing peer recoveries using snapshots.

Co-authored-by: Yang Wang <ywangd@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. Team:Distributed Meta label for distributed team. >test Issues or PRs that are addressing/adding tests v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants