Remove version dependent logic from CompletionFieldMapper#113011
Merged
javanna merged 1 commit intoelastic:mainfrom Sep 18, 2024
Merged
Remove version dependent logic from CompletionFieldMapper#113011javanna merged 1 commit intoelastic:mainfrom
javanna merged 1 commit intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Collaborator
|
Hi @javanna, I've created a changelog YAML for you. Note that since this PR is labelled |
We have version based logic that applies the limit to number of completion contexts only to indices created from 8.0 on. Those are the only indices we can now have in a cluster, hence we can remove the version based conditional. Relates to elastic#38675
6a64096 to
342f22b
Compare
cbuescher
added a commit
to cbuescher/elasticsearch
that referenced
this pull request
Dec 19, 2024
…astic#113011)" This reverts commit 452a4d2.
cbuescher
added a commit
that referenced
this pull request
Dec 20, 2024
This has been removed previously with #113011 but needs to be added back for v7 read-only compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have version based logic that applies the limit to number of completion contexts only to indices created from 8.0 on. All indices we may now have in a 9.x cluster match that conditional, hence we can remove the version based conditional.
Relates to #38675