Skip to content

[Cloud Security] add privileges required for CDR misconfiguration features to work#112456

Merged
maxcold merged 1 commit intoelastic:mainfrom
maxcold:csp-add-wiz-misconfigruation-transform-piviliges
Sep 5, 2024
Merged

[Cloud Security] add privileges required for CDR misconfiguration features to work#112456
maxcold merged 1 commit intoelastic:mainfrom
maxcold:csp-add-wiz-misconfigruation-transform-piviliges

Conversation

@maxcold
Copy link
Copy Markdown
Contributor

@maxcold maxcold commented Sep 3, 2024

Summary

This PR updates kibana_system privileges to include the ones required for the Security Solution CDR Misconfigurtion latest transform to work:

  • to read from source Wiz data stream as one of the data streams providing data for Cloud Detection & Response (CDR) features in Kibana
  • to create a destination CDR Misconfiguration index with an alias and write data to it

Related integration PR with the transform implementation

@maxcold maxcold added Team:Cloud Security Meta label for Cloud Security team v8.16.0 labels Sep 3, 2024
@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Sep 3, 2024
@maxcold maxcold marked this pull request as ready for review September 3, 2024 13:33
@maxcold maxcold requested a review from a team as a code owner September 3, 2024 13:33
@maxcold maxcold added >non-issue :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC and removed external-contributor Pull request authored by a developer outside the Elasticsearch team labels Sep 3, 2024
@maxcold
Copy link
Copy Markdown
Contributor Author

maxcold commented Sep 4, 2024

/ci

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Sep 4, 2024
Copy link
Copy Markdown
Contributor

@CohenIdo CohenIdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the Kibana Security perspective. Can we make sure this pattern is also covered by the docs mentioned here: #112192 (comment)?

Thanks for the detailed justification in the issue description! This definitely makes the review easier and faster.

RoleDescriptor.IndicesPrivileges.builder()
// manage privilege required by the index alias
.indices("security_solution-*.vulnerability_latest")
.indices("security_solution-*.vulnerability_latest", "security_solution-*.misconfiguration_latest")
Copy link
Copy Markdown

@kfirpeled kfirpeled Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far our naming convention was plural

vulnerabilities, findings. Also alerts and logs.
Maybe worth to keep it this way as a convention

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention I see in other packages to have data sources named as singular, same for ti latest IoC transforms. So I'd leave the more common convention and maybe change our naming when we get to getting rid of logs-* prefix

@maxcold maxcold merged commit 7800e99 into elastic:main Sep 5, 2024
@maxcold maxcold deleted the csp-add-wiz-misconfigruation-transform-piviliges branch September 5, 2024 16:10
kcreddy added a commit that referenced this pull request Sep 10, 2024
…to CDR misconfiguration features (#112574)

Update `kibana_system` privileges to include the ones required for the Security Solution CDR Misconfiguration latest transform to work on AWS SecurityHub integration:
  - to read from source AWS SecurityHub Findings data stream as one of the data streams providing data for Cloud Detection & Response (CDR) features in Kibana.

The destination and alias index privileges already added in #112456.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Cloud Security Meta label for Cloud Security team Team:Security Meta label for security team v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants