Full coverage of ECS by ecs@mappings when date_detection is disabled#112444
Merged
eyalkoren merged 6 commits intoelastic:mainfrom Sep 9, 2024
Merged
Full coverage of ECS by ecs@mappings when date_detection is disabled#112444eyalkoren merged 6 commits intoelastic:mainfrom
eyalkoren merged 6 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @eyalkoren, I've created a changelog YAML for you. |
felixbarny
reviewed
Sep 3, 2024
.../plugin/stack/src/javaRestTest/java/org/elasticsearch/xpack/stack/EcsDynamicTemplatesIT.java
Outdated
Show resolved
Hide resolved
felixbarny
approved these changes
Sep 4, 2024
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
eyalkoren
added a commit
to eyalkoren/elasticsearch
that referenced
this pull request
Sep 9, 2024
…lastic#112444) (cherry picked from commit 86a3eff) # Conflicts: # x-pack/plugin/stack/src/javaRestTest/java/org/elasticsearch/xpack/stack/EcsDynamicTemplatesIT.java # x-pack/plugin/stack/src/main/java/org/elasticsearch/xpack/stack/StackTemplateRegistry.java
eyalkoren
added a commit
that referenced
this pull request
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112398
The new test that I added highlighted something that I think is unexpected - it seems that automatic date detection is applied BEFORE all dynamic templates are matched to the incoming fields.
When setting
date_detection: falseand usingecs@mappings, some ECS fields get the wrong mapping, but they get the right mapping whendate_detection: true. This shouldn't be the case, because the last dynamic template inecs@mappingsacts as a fallback to allstringvalues, mapping then tokeywordif they are not matched by any other dynamic template, which is effectively disabling date detection for strings.