Skip to content

Upgrade Byte Buddy to 1.14.12#112390

Merged
ChrisHegarty merged 2 commits intoelastic:mainfrom
ChrisHegarty:bb_bump
Aug 30, 2024
Merged

Upgrade Byte Buddy to 1.14.12#112390
ChrisHegarty merged 2 commits intoelastic:mainfrom
ChrisHegarty:bb_bump

Conversation

@ChrisHegarty
Copy link
Copy Markdown
Contributor

@ChrisHegarty ChrisHegarty commented Aug 30, 2024

This commit bumps the Byte Buddy version to 1.14.12. This is needed to support class file versions generated by Java 21.

We already use this version of Byte Buddy elsewhere, so there is not need to update the gradle verification metadata.

This change is in preparation for an eventual bump of Elasticsearch to a minimum of JDK 21, in ES 9.0.

relates: #112252

@ChrisHegarty ChrisHegarty added >test Issues or PRs that are addressing/adding tests :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v8.16.0 labels Aug 30, 2024
@ChrisHegarty ChrisHegarty requested a review from breskeby August 30, 2024 11:28
@ChrisHegarty ChrisHegarty requested a review from a team as a code owner August 30, 2024 11:28
@ChrisHegarty ChrisHegarty mentioned this pull request Aug 30, 2024
Merged
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Aug 30, 2024

Pinging @elastic/es-delivery (Team:Delivery)

@ChrisHegarty
Copy link
Copy Markdown
Contributor Author

ChrisHegarty commented Aug 30, 2024

Here's the observed failure without the old version:

StablePluginBuildPluginFuncTest > can build stable plugin properties FAILED
    java.lang.IllegalArgumentException: Java 21 (65) is not supported by the current version of Byte Buddy which officially supports Java 19 (63) - update Byte Buddy or set net.bytebuddy.experimental as a VM property
        at net.bytebuddy.utility.OpenedClassReader.of(OpenedClassReader.java:96)
        at net.bytebuddy.dynamic.scaffold.TypeWriter$Default$ForInlining.create(TypeWriter.java:3948)
        at net.bytebuddy.dynamic.scaffold.TypeWriter$Default.make(TypeWriter.java:2213)
        at net.bytebuddy.dynamic.scaffold.inline.RedefinitionDynamicTypeBuilder.make(RedefinitionDynamicTypeBuilder.java:224)
        at net.bytebuddy.dynamic.scaffold.inline.AbstractInliningDynamicTypeBuilder.make(AbstractInliningDynamicTypeBuilder.java:123)
        at net.bytebuddy.dynamic.DynamicType$Builder$AbstractBase.make(DynamicType.java:3668)
        at org.elasticsearch.gradle.fixtures.TestClasspathUtils.setupNamedComponentScanner(TestClasspathUtils.groovy:37)
        at org.elasticsearch.gradle.plugin.StablePluginBuildPluginFuncTest.setup(StablePluginBuildPluginFuncTest.groovy:52)

StablePluginBuildPluginFuncTest > can scan and create named components file FAILED
    java.lang.IllegalArgumentException: Java 21 (65) is not supported by the current version of Byte Buddy which officially supports Java 19 (63) - update Byte Buddy or set net.bytebuddy.experimental as a VM property
        at net.bytebuddy.utility.OpenedClassReader.of(OpenedClassReader.java:96)
        at net.bytebuddy.dynamic.scaffold.TypeWriter$Default$ForInlining.create(TypeWriter.java:3948)
        at net.bytebuddy.dynamic.scaffold.TypeWriter$Default.make(TypeWriter.java:2213)
        at net.bytebuddy.dynamic.scaffold.inline.RedefinitionDynamicTypeBuilder.make(RedefinitionDynamicTypeBuilder.java:224)
        at net.bytebuddy.dynamic.scaffold.inline.AbstractInliningDynamicTypeBuilder.make(AbstractInliningDynamicTypeBuilder.java:123)
        at net.bytebuddy.dynamic.DynamicType$Builder$AbstractBase.make(DynamicType.java:3668)
        at org.elasticsearch.gradle.fixtures.TestClasspathUtils.setupNamedComponentScanner(TestClasspathUtils.groovy:37)
        at org.elasticsearch.gradle.plugin.StablePluginBuildPluginFuncTest.setup(StablePluginBuildPluginFuncTest.groovy:52)

breskeby
breskeby approved these changes Aug 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@breskeby breskeby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove version 1.12.10 from gradle/verification-metadata.xml ?

@ChrisHegarty ChrisHegarty merged commit 0489a37 into elastic:main Aug 30, 2024
@ChrisHegarty ChrisHegarty deleted the bb_bump branch August 30, 2024 13:54
dakrone pushed a commit to dakrone/elasticsearch that referenced this pull request Aug 30, 2024
@ChrisHegarty @dakrone
Upgrade Byte Buddy to 1.14.12 (elastic#112390)
689e723 
This commit bumps the Byte Buddy version to 1.14.12. This is needed to support class file versions generated by Java 21.

We already use this version of Byte Buddy elsewhere, so there is not need to update the gradle verification metadata.

This change is in preparation for an eventual bump of Elasticsearch to a minimum of JDK 21, in ES 9.0.
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Sep 4, 2024
@ChrisHegarty @cbuescher
Upgrade Byte Buddy to 1.14.12 (elastic#112390)
e9f0c01 
This commit bumps the Byte Buddy version to 1.14.12. This is needed to support class file versions generated by Java 21.

We already use this version of Byte Buddy elsewhere, so there is not need to update the gradle verification metadata.

This change is in preparation for an eventual bump of Elasticsearch to a minimum of JDK 21, in ES 9.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breskeby breskeby breskeby approved these changes

Assignees

No one assigned

Labels

:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v8.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChrisHegarty @elasticsearchmachine @breskeby