Pass allow security manager flag in gradle test policy setup plugin#111725
Merged
elasticsearchmachine merged 1 commit intoelastic:mainfrom Aug 8, 2024
Merged
Conversation
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
rjernst
approved these changes
Aug 8, 2024
Member
rjernst
left a comment
There was a problem hiding this comment.
This looks fine, but I suspect we need more. Other stuff we do in ElasticsearchTestBasePlugin is needed like setting up java.library.path/jna.library.path
Contributor
Author
Probably, it's likely our example plugin tests just aren't exercising that code. |
john-wagster
approved these changes
Aug 8, 2024
Contributor
john-wagster
left a comment
There was a problem hiding this comment.
LGTM, fixes an issues I accidentally stumbled upon when trying to run yaml tests against the plugin build with jdk 22.
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Aug 8, 2024
…lastic#111725) The `java.security.manager=allow` system property is required when running tests on newer Java versions with the security manager deprecated. As such, it should be set in our `GradleTestPolicySetupPlugin` so that it's done for external plugin authors.
Collaborator
💚 Backport successful
|
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Aug 9, 2024
* upstream/main: (22 commits) Prune changelogs after 8.15.0 release Bump versions after 8.15.0 release EIS integration (elastic#111154) Skip LOOKUP/INLINESTATS cases unless on snapshot (elastic#111755) Always enforce strict role validation (elastic#111056) Mute org.elasticsearch.xpack.esql.analysis.VerifierTests testUnsupportedAndMultiTypedFields elastic#111753 [ML] Force time shift integration test (elastic#111620) ESQL: Add tests for sort, where with unsupported type (elastic#111737) [ML] Force time shift documentation (elastic#111668) Fix remote cluster credential secure settings reload (elastic#111535) ESQL: Fix for overzealous validation in case of invalid mapped fields (elastic#111475) Pass allow security manager flag in gradle test policy setup plugin (elastic#111725) Rename streamContent/Separator to bulkContent/Separator (elastic#111716) Mute org.elasticsearch.tdigest.ComparisonTests testSparseGaussianDistribution elastic#111721 Remove 8.14 from branches.json Only emit product origin in deprecation log if present (elastic#111683) Forward port release notes for v8.15.0 (elastic#111714) [ES|QL] Combine Disjunctive CIDRMatch (elastic#111501) ESQL: Remove qualifier from attrs (elastic#110581) Force using the last centroid during merging (elastic#111644) ... # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/InferenceNamedWriteablesProvider.java
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
…lastic#111725) The `java.security.manager=allow` system property is required when running tests on newer Java versions with the security manager deprecated. As such, it should be set in our `GradleTestPolicySetupPlugin` so that it's done for external plugin authors.
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Sep 5, 2024
…lastic#111725) The `java.security.manager=allow` system property is required when running tests on newer Java versions with the security manager deprecated. As such, it should be set in our `GradleTestPolicySetupPlugin` so that it's done for external plugin authors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
java.security.manager=allowsystem property is required when running tests on newer Java versions with the security manager deprecated. As such, it should be set in ourGradleTestPolicySetupPluginso that it's done for external plugin authors.