Skip to content

Fix blob-not-found handling in AzureBlobContainer#111589

Merged
elasticsearchmachine merged 3 commits intoelastic:mainfrom
DaveCTurner:2024/08/05/AzureBlobContainer-blob-not-found
Aug 5, 2024
Merged

Fix blob-not-found handling in AzureBlobContainer#111589
elasticsearchmachine merged 3 commits intoelastic:mainfrom
DaveCTurner:2024/08/05/AzureBlobContainer-blob-not-found

Conversation

@DaveCTurner
Copy link
Copy Markdown
Member

The upgrade to the Azure SDK in #111225 changed how exceptions are
thrown when reading a blob, such that the relevant HTTP exception is not
necessarily the innermost cause. With this commit we check every
exception along the way to see if it contains the HTTP status code.

Closes #111233

The upgrade to the Azure SDK in elastic#111225 changed how exceptions are
thrown when reading a blob, such that the relevant HTTP exception is not
necessarily the innermost cause. With this commit we check every
exception along the way to see if it contains the HTTP status code.

Closes elastic#111233
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.16.0 labels Aug 5, 2024
@DaveCTurner DaveCTurner requested a review from ywangd August 5, 2024 13:32
@DaveCTurner DaveCTurner added >non-issue and removed >test Issues or PRs that are addressing/adding tests labels Aug 5, 2024
@DaveCTurner
Copy link
Copy Markdown
Member Author

>non-issue because this hasn't been released

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team. label Aug 5, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Aug 5, 2024
@elasticsearchmachine elasticsearchmachine merged commit f2952a8 into elastic:main Aug 5, 2024
@DaveCTurner DaveCTurner deleted the 2024/08/05/AzureBlobContainer-blob-not-found branch August 5, 2024 17:00
mhl-b pushed a commit that referenced this pull request Aug 8, 2024
The upgrade to the Azure SDK in #111225 changed how exceptions are
thrown when reading a blob, such that the relevant HTTP exception is not
necessarily the innermost cause. With this commit we check every
exception along the way to see if it contains the HTTP status code.

Closes #111233
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Sep 4, 2024
The upgrade to the Azure SDK in elastic#111225 changed how exceptions are
thrown when reading a blob, such that the relevant HTTP exception is not
necessarily the innermost cause. With this commit we check every
exception along the way to see if it contains the HTTP status code.

Closes elastic#111233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue Team:Distributed Meta label for distributed team. v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] AzureBlobContainerRetriesTests testReadNonexistentBlobThrowsNoSuchFileException failing

3 participants