[ESQL} Remove unused core binary comparison classes#110891
Merged
elasticsearchmachine merged 1 commit intoelastic:mainfrom Jul 15, 2024
Merged
[ESQL} Remove unused core binary comparison classes#110891elasticsearchmachine merged 1 commit intoelastic:mainfrom
elasticsearchmachine merged 1 commit intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
tvernum
pushed a commit
that referenced
this pull request
Feb 25, 2025
Quick cleanup PR. With #109413 merged, nothing in ESQL production depends on the core binary comparison classes anymore. This PR removes them to avoid the potential for confusion, and open the opportunity for merging the core `BinaryComparison` class with the `EsqlBinaryComparison` base class, which is now its only direct inheritor (work to be done in a future PR).
tvernum
pushed a commit
that referenced
this pull request
Feb 25, 2025
Quick cleanup PR. With #109413 merged, nothing in ESQL production depends on the core binary comparison classes anymore. This PR removes them to avoid the potential for confusion, and open the opportunity for merging the core `BinaryComparison` class with the `EsqlBinaryComparison` base class, which is now its only direct inheritor (work to be done in a future PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick cleanup PR. With #109413 merged, nothing in ESQL production depends on the core binary comparison classes anymore. This PR removes them to avoid the potential for confusion, and open the opportunity for merging the core
BinaryComparisonclass with theEsqlBinaryComparisonbase class, which is now its only direct inheritor (work to be done in a future PR).