Add leak tracking and unmute Netty4ChunkedContinuationsIT#110175
Merged
nicktindall merged 3 commits intoelastic:mainfrom Jun 26, 2024
Merged
Conversation
Related to: 109866
nicktindall
commented
Jun 26, 2024
...src/internalClusterTest/java/org/elasticsearch/http/netty4/Netty4ChunkedContinuationsIT.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
nicktindall
commented
Jun 26, 2024
| } finally { | ||
| refs = null; | ||
| reachabilityChecker.ensureUnreachable(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The LeakTracker will log the sequence of incRef and decRef that resulted in the failure, the ReachabilityChecker will ensure we wait for the LeakTracker to kick in during the test.
ywangd
approved these changes
Jun 26, 2024
...src/internalClusterTest/java/org/elasticsearch/http/netty4/Netty4ChunkedContinuationsIT.java
Outdated
Show resolved
Hide resolved
…ticsearch/http/netty4/Netty4ChunkedContinuationsIT.java Co-authored-by: Yang Wang <ywangd@gmail.com>
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jun 30, 2024
With the changes in elastic#109519 we now do one more async step while serving the response, so we need to acquire another ref to track the new step. Relates elastic#109866 Relates elastic#110118 Relates elastic#110175 Relates elastic#110249
DaveCTurner
added a commit
that referenced
this pull request
Jul 1, 2024
Member
|
FWIW this failure did reproduce for me locally, although it's not unusual for things like this to take a few hours of iterations to catch the culprit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #109866
I've had great difficulty in reproducing this failure, this change should give us more information about where the issue is