Skip to content

ESQL: Move serialization of DataType#109184

Merged
nik9000 merged 1 commit intoelastic:mainfrom
nik9000:esql_serialize_data_type
May 30, 2024
Merged

ESQL: Move serialization of DataType#109184
nik9000 merged 1 commit intoelastic:mainfrom
nik9000:esql_serialize_data_type

Conversation

@nik9000
Copy link
Copy Markdown
Member

@nik9000 nik9000 commented May 29, 2024

This moves the serialization of DataType from PlanNamedTypes and into DataType itself to better align with the rest of Elasticsearch.

This moves the serialization of `DataType` from `PlanNamedTypes` and
into `DataType` itself to better align with the rest of Elasticsearch.
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 29, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Copy Markdown
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000 nik9000 merged commit f5cc990 into elastic:main May 30, 2024
@nik9000
Copy link
Copy Markdown
Member Author

nik9000 commented May 30, 2024

Thanks @bpintea !

nik9000 added a commit to nik9000/elasticsearch that referenced this pull request May 30, 2024
This moves the serialization of `DataType` from `PlanNamedTypes` and
into `DataType` itself to better align with the rest of Elasticsearch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants