[Osquery] Extend kibana_system role with an access to new osquery_manager index#108849
Merged
szwarckonrad merged 7 commits intoelastic:mainfrom May 23, 2024
Conversation
Collaborator
|
Hi @szwarckonrad, I've created a changelog YAML for you. |
Contributor
|
@elasticmachine test this please |
Contributor
|
ok to test |
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
…ttps://github.com/szwarckonrad/elasticsearch into feat/extend-kibana-system-osquery-index-permissions
kc13greiner
approved these changes
May 22, 2024
Contributor
There was a problem hiding this comment.
LGTM!
The new privileges are being added for a data index that matches the known collision pattern logs-* so we can allow this privilege. This pattern is documented here
slobodanadamovic
approved these changes
May 23, 2024
szwarckonrad
added a commit
to elastic/kibana
that referenced
this pull request
May 24, 2024
…#183892) **Prerequisite**: elastic/elasticsearch#108849 **Follow-up**: elastic/integrations#9661 This PR introduces a new index `logs-osquery_manager.action.responses-default` for action responses. This index will be added in Osquery Manager integration version `1.12` and will replace the existing `.logs-osquery_manager.action.responses-default`, which is currently populated by a transform from `.fleet-actions`. Since most users will still be using the old integration package, we ensured that the implementation checks the old index first and returns the response from there unless the new index is available. If the new index is available, the response will come from it. This change ensures compatibility with all user scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the
kibana_systemrole to include access to the new indexlogs-osquery_manager.action.responses. Previously, we used the.logs-osquery_manager.action.responsesindex, which stored data from a transform. We are now implementing a solution whereosquerybeatwrites directly tologs-osquery_manager.action.responses, removing the need for the transform. The existing index is marked as "Legacy" and will still be used by anyone who does not upgrade Kibana to version8.15and the Osquery integration to version1.12.Follow up: elastic/kibana#183892