Two empty mappings now are created equally#107936
Merged
piergm merged 15 commits intoelastic:mainfrom Sep 12, 2024
Merged
Conversation
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Collaborator
|
Hi @piergm, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Contributor
|
@piergm does this need review? |
…tly-in-field_caps
…tly-in-field_caps
mark-vieira
approved these changes
Sep 4, 2024
Member
|
Is it possible to get this bug fixed and backported to 8.x in the near future ? The fix looks contained and the bug keeps occurring every now and then. Thanks! |
Collaborator
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
piergm
added a commit
to piergm/elasticsearch
that referenced
this pull request
Sep 12, 2024
* Two empty mappings reported equally in field_caps
* empty mapping now is {}
* iter
(cherry picked from commit cd8d37b)
Member
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
piergm
added a commit
that referenced
this pull request
Sep 12, 2024
davidkyle
pushed a commit
that referenced
this pull request
Sep 12, 2024
* Two empty mappings reported equally in field_caps
* empty mapping now is {}
* iter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mapping defaults to
{}aka EMPTY_MAPPING, even ifmappings: {}is passed in the request body to match the behaviour when passing empty mapping on index create.Prior to this change
mappings: {}was instead wrapped with with_docfixes #107031