Skip to content

ESQL: Estimate memory usage on Block.Builder#107923

Merged
nik9000 merged 1 commit intoelastic:mainfrom
nik9000:esql_builder_estimated_bytes_used
Apr 26, 2024
Merged

ESQL: Estimate memory usage on Block.Builder#107923
nik9000 merged 1 commit intoelastic:mainfrom
nik9000:esql_builder_estimated_bytes_used

Conversation

@nik9000
Copy link
Copy Markdown
Member

@nik9000 nik9000 commented Apr 25, 2024

This adds a method to Block.Builder that estimates the number of bytes that'll be used by the Block that it builds. It's not always accurate, but it is directional.

This adds a method to `Block.Builder` that estimates the number of bytes
that'll be used by the `Block` that it builds. It's not always accurate,
but it is directional.
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 25, 2024
* underestimate it.
*/
long estimatedBytes();

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are on Block.Builder now.

Copy link
Copy Markdown
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nik9000 nik9000 merged commit fccb2e7 into elastic:main Apr 26, 2024
@nik9000
Copy link
Copy Markdown
Member Author

nik9000 commented Apr 26, 2024

Thanks @dnhatn !

elasticsearchmachine pushed a commit that referenced this pull request Jun 7, 2024
This adds support for `LOOKUP`, a command that implements a sort of
inline `ENRICH`, using data that is passed in the request:

```
$ curl -uelastic:password -HContent-Type:application/json -XPOST \
    'localhost:9200/_query?error_trace&pretty&format=txt' \
-d'{
    "query": "ROW a=1::LONG | LOOKUP t ON a",
    "tables": {
        "t": {
            "a:long":     [    1,     4,     2],
            "v1:integer": [   10,    11,    12],
            "v2:keyword": ["cat", "dog", "wow"]
        }
    },
    "version": "2024.04.01"
}'
      v1       |      v2       |       a       
---------------+---------------+---------------
10             |cat            |1
```

This required these PRs: * #107624 * #107634 * #107701 * #107762 *
#107923 * #107894 * #107982 * #108012 * #108020 * #108169 * #108191 *
#108334 * #108482 * #108696 * #109040 * #109045

Closes #107306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants