ESQL: Document BUCKET as a grouping function#107864
Merged
elasticsearchmachine merged 5 commits intoelastic:mainfrom Apr 25, 2024
Merged
ESQL: Document BUCKET as a grouping function#107864elasticsearchmachine merged 5 commits intoelastic:mainfrom
elasticsearchmachine merged 5 commits intoelastic:mainfrom
Conversation
This adds the documentation for BUCKET as a grouping function and the addition of the "direct" invokation mode providing a span (besides the auto mode).
Contributor
|
Documentation preview: |
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
reviewed
Apr 25, 2024
Contributor
alex-spies
left a comment
There was a problem hiding this comment.
I think we should update the parameter descriptions as well, to mention that from and to can be omitted (together):
x-pack/plugin/esql/qa/testFixtures/src/main/resources/bucket.csv-spec
Outdated
Show resolved
Hide resolved
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/grouping/Bucket.java
Show resolved
Hide resolved
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/grouping/Bucket.java
Show resolved
Hide resolved
alex-spies
approved these changes
Apr 25, 2024
Contributor
Author
|
Thanks, Alex! |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Apr 25, 2024
This adds the documentation for BUCKET as a grouping function and the addition of the "direct" invocation mode providing a span (in addition to the auto mode). (cherry picked from commit a212420)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the documentation for BUCKET as a grouping function and the addition of the "direct" invocation mode providing a span (in addition to the auto mode).