Make o.e.index.codec.ForUtil a pure utility class#107348
Merged
original-brownbear merged 1 commit intoelastic:mainfrom Apr 11, 2024
original-brownbear:for-util-static
Merged
Make o.e.index.codec.ForUtil a pure utility class#107348original-brownbear merged 1 commit intoelastic:mainfrom original-brownbear:for-util-static
original-brownbear merged 1 commit intoelastic:mainfrom
original-brownbear:for-util-static
Conversation
We've run into heap dumps that had instances of this class consume tens and in one case more than a hundred MB of heap. It seems reasonable to use a thread-local for the `tmp` long array and trade the cost of looking up the thread-local for the memory savings and cycles saved for allocating and assigning instances.
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
iverase
approved these changes
Apr 11, 2024
Contributor
iverase
left a comment
There was a problem hiding this comment.
interesting approach , lgtm
Contributor
Author
|
Thanks Ignacio! |
craigtaverner
pushed a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Apr 11, 2024
We've run into heap dumps that had instances of this class consume tens and in one case more than a hundred MB of heap. It seems reasonable to use a thread-local for the `tmp` long array and trade the cost of looking up the thread-local for the memory savings and cycles saved for allocating and assigning instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've run into heap dumps that had instances of this class consume tens and in one case more than a hundred MB of heap.
It seems reasonable to use a thread-local for the
tmplong array and trade the cost of looking up the thread-local for the memory savings and cycles saved for allocating and assigning instances and from moving to astaticcall everywhere.