[ML] Rerank response format change#107288
Merged
maxhniebergall merged 14 commits intomainfrom Apr 10, 2024
Merged
Conversation
added 3 commits
April 9, 2024 16:51
…rerankImprovements # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
...erence/src/main/java/org/elasticsearch/xpack/inference/InferenceNamedWriteablesProvider.java
Show resolved
Hide resolved
...a/org/elasticsearch/xpack/inference/external/response/cohere/CohereRankedResponseEntity.java
Outdated
Show resolved
Hide resolved
...a/org/elasticsearch/xpack/inference/external/response/cohere/CohereRankedResponseEntity.java
Outdated
Show resolved
Hide resolved
...gin/core/src/main/java/org/elasticsearch/xpack/core/inference/results/RankedDocsResults.java
Show resolved
Hide resolved
added 2 commits
April 10, 2024 12:35
…rerankImprovements # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
davidkyle
reviewed
Apr 10, 2024
...gin/core/src/main/java/org/elasticsearch/xpack/core/inference/results/RankedDocsResults.java
Outdated
Show resolved
Hide resolved
...a/org/elasticsearch/xpack/inference/external/response/cohere/CohereRankedResponseEntity.java
Outdated
Show resolved
Hide resolved
…inference/results/RankedDocsResults.java Co-authored-by: David Kyle <david.kyle@elastic.co>
jonathan-buttner
approved these changes
Apr 10, 2024
added 6 commits
April 10, 2024 15:08
…rerankImprovements # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
…rerankImprovements
…rerankImprovements
…rerankImprovements
craigtaverner
pushed a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Apr 11, 2024
* Change rerank result types, add named writables, new transportVersion * Add description for namedWriteables * fix RankedDocsResults toString --------- Co-authored-by: David Kyle <david.kyle@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the response format of the Cohere Rerank inference endpoint. Previously, the field values
relevance_scoreandindexwere Strings, and now they will befloatandint, respectively.Elasticsearch-spec PR to follow.