[Connector API] Support cleaning up sync jobs when deleting a connector#107253
Merged
jedrazb merged 16 commits intoelastic:mainfrom Apr 11, 2024
Merged
Conversation
Collaborator
|
Hi @jedrazb, I've created a changelog YAML for you. |
jedrazb
commented
Apr 9, 2024
| testImplementation(testArtifact(project(xpackModule('core')))) | ||
| testImplementation project(":test:framework") | ||
| testImplementation(project(':modules:lang-mustache')) | ||
| testImplementation(project(':modules:reindex')) |
Contributor
Author
There was a problem hiding this comment.
It seems to be needed for ESSingleNodeTestCase to register Reindex plugin that exposes delete_by_query action
Collaborator
|
Pinging @elastic/ent-search-eng (Team:Enterprise Search) |
timgrein
approved these changes
Apr 9, 2024
Contributor
timgrein
left a comment
There was a problem hiding this comment.
Just some minor comments, LGTM
...rch/qa/rest/src/yamlRestTest/resources/rest-api-spec/test/entsearch/320_connector_delete.yml
Show resolved
Hide resolved
...earch/src/main/java/org/elasticsearch/xpack/application/connector/ConnectorIndexService.java
Outdated
Show resolved
Hide resolved
...earch/src/main/java/org/elasticsearch/xpack/application/connector/ConnectorIndexService.java
Outdated
Show resolved
Hide resolved
...earch/src/main/java/org/elasticsearch/xpack/application/connector/ConnectorIndexService.java
Outdated
Show resolved
Hide resolved
...ain/java/org/elasticsearch/xpack/application/connector/action/RestDeleteConnectorAction.java
Outdated
Show resolved
Hide resolved
...java/org/elasticsearch/xpack/application/connector/syncjob/ConnectorSyncJobIndexService.java
Outdated
Show resolved
Hide resolved
...java/org/elasticsearch/xpack/application/connector/syncjob/ConnectorSyncJobIndexService.java
Outdated
Show resolved
Hide resolved
...t-search/src/test/java/org/elasticsearch/xpack/application/connector/ConnectorTestUtils.java
Outdated
Show resolved
Hide resolved
…/application/connector/ConnectorIndexService.java Co-authored-by: Tim Grein <tim@4greins.de>
…/application/connector/ConnectorIndexService.java Co-authored-by: Tim Grein <tim@4greins.de>
…/application/connector/ConnectorIndexService.java Co-authored-by: Tim Grein <tim@4greins.de>
…/application/connector/syncjob/ConnectorSyncJobIndexService.java Co-authored-by: Tim Grein <tim@4greins.de>
…/application/connector/syncjob/ConnectorSyncJobIndexService.java Co-authored-by: Tim Grein <tim@4greins.de>
…/application/connector/ConnectorTestUtils.java Co-authored-by: Tim Grein <tim@4greins.de>
craigtaverner
pushed a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
delete_sync_jobsURL param for the delete requesttrueby default, example of how to opt out:DELETE _connector/{id}?delete_sync_jobs=falsedelete_by_queryunder the hood I needed to linkReindexplugin for unit tests inbuild.gradleAwaitsFixfor the issue linked to missing template mappings - I will follow up in next PR to check if all of the tests are fixed now