Add failure store option to modify data stream API#107116
Merged
elasticsearchmachine merged 16 commits intoelastic:mainfrom Apr 10, 2024
Merged
Add failure store option to modify data stream API#107116elasticsearchmachine merged 16 commits intoelastic:mainfrom
elasticsearchmachine merged 16 commits intoelastic:mainfrom
Conversation
…r state task logic.
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
nielsbauman
reviewed
Apr 5, 2024
Contributor
nielsbauman
left a comment
There was a problem hiding this comment.
This is looking good! Left a couple of comments, but most should be pretty easy to resolve.
...streams/src/yamlRestTest/resources/rest-api-spec/test/data_stream/170_modify_data_stream.yml
Outdated
Show resolved
Hide resolved
...streams/src/yamlRestTest/resources/rest-api-spec/test/data_stream/170_modify_data_stream.yml
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/DataStreamAction.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataDataStreamsService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataMigrateToDataStreamService.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/metadata/DataStreamTests.java
Outdated
Show resolved
Hide resolved
…test/data_stream/170_modify_data_stream.yml Co-authored-by: Niels Bauman <33722607+nielsbauman@users.noreply.github.com>
gmarouli
reviewed
Apr 8, 2024
gmarouli
reviewed
Apr 8, 2024
server/src/test/java/org/elasticsearch/cluster/metadata/DataStreamTests.java
Outdated
Show resolved
Hide resolved
nielsbauman
reviewed
Apr 8, 2024
gmarouli
reviewed
Apr 8, 2024
server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataMigrateToDataStreamService.java
Outdated
Show resolved
Hide resolved
nielsbauman
approved these changes
Apr 10, 2024
Contributor
nielsbauman
left a comment
There was a problem hiding this comment.
+1 from me too, we're picking up some pace with failure stores!
craigtaverner
pushed a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Apr 11, 2024
This PR adds the ability to modify the failure store indices on a data stream using the modify data stream API. These options are available in the event that we need to pull indices out of a failure store or add them back to the failure store for any reason. The operations are done using the existing modify data stream actions with a new flag on the action body to denote if the action should be done on the failure stores or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to modify the failure store indices on a data stream using the modify data stream API.
These options are available in the event that we need to pull indices out of a failure store or add them back to the failure store for any reason. The operations are done using the existing modify data stream actions with a new flag on the action body to denote if the action should be done on the failure stores or not.