MockLogAppender takes string logger names for capturing#104971
Merged
elasticsearchmachine merged 2 commits intoelastic:mainfrom Jan 31, 2024
Merged
MockLogAppender takes string logger names for capturing#104971elasticsearchmachine merged 2 commits intoelastic:mainfrom
elasticsearchmachine merged 2 commits intoelastic:mainfrom
Conversation
For classes that are not publically accessible, we can use the cannoical names for capturing.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ywangd
commented
Jan 31, 2024
| blobStore.bucket(), | ||
| blobKey, | ||
| purpose, | ||
| purpose.getKey(), |
Member
Author
There was a problem hiding this comment.
Irrelevant to this PR. But it's too trivial to have its own PR.
DaveCTurner
approved these changes
Jan 31, 2024
| } | ||
|
|
||
| public Releasable capturing(String... names) { | ||
| final var loggers = Arrays.stream(names).map(LogManager::getLogger).toArray(Logger[]::new); |
Member
There was a problem hiding this comment.
nit: not sure why I used toArray here in the first place, toList() would be neater
Member
Author
There was a problem hiding this comment.
Yep I updated both places to use toList.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For classes that are not publically accessible, we can use the cannoical names for capturing.