Skip to content

[Transform] Make _reset action stop transforms without force first#104870

Merged
przemekwitek merged 4 commits intoelastic:mainfrom
przemekwitek:fix_reset_transforms
Jan 30, 2024
Merged

[Transform] Make _reset action stop transforms without force first#104870
przemekwitek merged 4 commits intoelastic:mainfrom
przemekwitek:fix_reset_transforms

Conversation

@przemekwitek
Copy link
Copy Markdown

@przemekwitek przemekwitek commented Jan 29, 2024

This PR fixes _reset action the following way:

  • the _reset action now tries to _stop the transform without force but with timeout
  • only when this fails, it re-tries, this time with force set to true

Additionally, this PR unmutes the TestFeatureResetIT test case.

This PR will be backported to 8.12 once the test runs without failure for a week in main.

Closes #100596
Closes #104825

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @przemekwitek, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Jan 29, 2024
Copy link
Copy Markdown
Member

@prwhelan prwhelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Przemyslaw Witek added 2 commits January 30, 2024 09:35
Reduce logging level from warn to info.
@przemekwitek przemekwitek added v8.12.1 auto-backport Automatically create backport pull requests when merged labels Jan 30, 2024
@przemekwitek przemekwitek merged commit 44d5035 into elastic:main Jan 30, 2024
@przemekwitek przemekwitek deleted the fix_reset_transforms branch January 30, 2024 09:24
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💚 Backport successful

Status Branch Result
8.12

przemekwitek pushed a commit to przemekwitek/elasticsearch that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >bug :ml/Transform Transform Team:ML Meta label for the ML team v8.12.1 v8.13.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] TestFeatureResetIT testTransformFeatureReset failing org.elasticsearch.xpack.transform.integration.TestFeatureResetIT

3 participants