ILM introduce the check-ts-end-time-passed step#100179
Merged
elasticsearchmachine merged 5 commits intoelastic:mainfrom Oct 3, 2023
Merged
ILM introduce the check-ts-end-time-passed step#100179elasticsearchmachine merged 5 commits intoelastic:mainfrom
check-ts-end-time-passed step#100179elasticsearchmachine merged 5 commits intoelastic:mainfrom
Conversation
This introduce a new ILM step, the `check-ts-end-time-passed` step that'll wait for the `index.time_series.end_time` to lapse for TS indices before allowing ILM to proceed with the execution of the following actions: * downsample * forcemerge * readonly * searchable_snapshot * shrink TSDS indices are allowed to receive writes until the configured `index.time_series.end_time` time passes. This makes sure ILM doesn't block these indices from accepting writes prematurely.
Collaborator
|
Hi @andreidan, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-1 |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-2 Failure tracked already in #96723 |
martijnvg
approved these changes
Oct 3, 2023
Member
martijnvg
left a comment
There was a problem hiding this comment.
Left one testing comment. LGTM otherwise.
| } | ||
| Instant configuredEndTime = IndexSettings.TIME_SERIES_END_TIME.get(indexMetadata.getSettings()); | ||
| assert configuredEndTime != null : "a time series index must have an end time configured but [" + index.getName() + "] does not"; | ||
| if (Instant.now().isBefore(configuredEndTime)) { |
Member
There was a problem hiding this comment.
Maybe provide current time as a lambda function? This would allow unit tests to not rely on current time.
Contributor
Author
There was a problem hiding this comment.
Yes! Great shout. Done in a6ffc7d
Thanks Martijn
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-3 |
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Oct 3, 2023
This introduces a new ILM step, the `check-ts-end-time-passed` step that'll wait for the `index.time_series.end_time` to lapse for TS indices before allowing ILM to proceed with the execution of the following actions: * downsample * forcemerge * readonly * searchable_snapshot * shrink TSDS indices are allowed to receive writes until the configured `index.time_series.end_time` time passes. This makes sure ILM doesn't block these indices from accepting writes prematurely. NOTE: documentation is added in a subsequent PR Fixes elastic#99696 (cherry picked from commit 8bf8fc1) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Oct 3, 2023
This introduces a new ILM step, the `check-ts-end-time-passed` step that'll wait for the `index.time_series.end_time` to lapse for TS indices before allowing ILM to proceed with the execution of the following actions: * downsample * forcemerge * readonly * searchable_snapshot * shrink TSDS indices are allowed to receive writes until the configured `index.time_series.end_time` time passes. This makes sure ILM doesn't block these indices from accepting writes prematurely. NOTE: documentation is added in a subsequent PR Fixes elastic#99696
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 3, 2023
This introduces a new ILM step, the `check-ts-end-time-passed` step that'll wait for the `index.time_series.end_time` to lapse for TS indices before allowing ILM to proceed with the execution of the following actions: * downsample * forcemerge * readonly * searchable_snapshot * shrink TSDS indices are allowed to receive writes until the configured `index.time_series.end_time` time passes. This makes sure ILM doesn't block these indices from accepting writes prematurely. NOTE: documentation is added in a subsequent PR Fixes #99696
andreidan
added a commit
that referenced
this pull request
Oct 3, 2023
This introduces a new ILM step, the `check-ts-end-time-passed` step that'll wait for the `index.time_series.end_time` to lapse for TS indices before allowing ILM to proceed with the execution of the following actions: * downsample * forcemerge * readonly * searchable_snapshot * shrink TSDS indices are allowed to receive writes until the configured `index.time_series.end_time` time passes. This makes sure ILM doesn't block these indices from accepting writes prematurely. NOTE: documentation is added in a subsequent PR Fixes #99696 (cherry picked from commit 8bf8fc1) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new ILM step, the
check-ts-end-time-passedstep that'll wait for theindex.time_series.end_timeto lapse for TS indices before allowing ILM to proceed with the execution of the following actions:TSDS indices are allowed to receive writes until the configured
index.time_series.end_timetime passes. This makes sure ILM doesn't block these indices from accepting writes prematurely.NOTE: documentation is added in a subsequent PR
Fixes #99696