-
Notifications
You must be signed in to change notification settings - Fork 25.9k
Move file-based discovery to core/server #33030
Copy link
Copy link
Closed
Labels
:Delivery/BuildBuild or test infrastructureBuild or test infrastructure:Distributed/Discovery-PluginsAnything related to our integration plugins with EC2, GCP and AzureAnything related to our integration plugins with EC2, GCP and AzureTeam:DeliveryMeta label for Delivery teamMeta label for Delivery teamv6.4.1v6.5.0v7.0.0-beta1
Metadata
Metadata
Assignees
Labels
:Delivery/BuildBuild or test infrastructureBuild or test infrastructure:Distributed/Discovery-PluginsAnything related to our integration plugins with EC2, GCP and AzureAnything related to our integration plugins with EC2, GCP and AzureTeam:DeliveryMeta label for Delivery teamMeta label for Delivery teamv6.4.1v6.5.0v7.0.0-beta1
Type
Fields
Give feedbackNo fields configured for issues without a type.
Some of our integration tests as well as the REST tests currently use the unicast hosts list setting for node discovery. This list is statically defined at node startup, which makes it very inflexible. For the
AbstractDisruptionTestCases, for example, we do port scanning to find free ports in order to fix the ports used by each node so that we can properly setup the unicast hosts list before starting the nodes. This port scanning does not always work reliably.. For our REST tests, we have to wait for the first node to be started up and bound to a port before we can start up the other nodes, as we need to put the address:port of the first node into the unicast hosts list of the other nodes. If we had something more flexible to achieve the same, this could really simplify our test infrastructure while also making it more resilient. Fortunately, such a more flexible node discovery already exists: it's the file-based discovery which is currently packaged as a plugin. The proposal here is to move the file-based discovery to the server project, so that it can be readily used in the testing framework for bothAbstractDisruptionTestCaseas well as all REST tests./cc: @franekrichardson