Ignore deprecated release tag from manifests#647
Conversation
go.mod
Outdated
| sigs.k8s.io/yaml v1.2.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/elastic/package-spec v1.3.0 => github.com/jsoriano/package-spec v0.0.0-20220112095620-98e0d531845d |
There was a problem hiding this comment.
This change won't be included.
There was a problem hiding this comment.
I understand that this PR is blocked on the other one: elastic/package-spec#256?
bc49663 to
5cf33c8
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
5cf33c8 to
b719f91
Compare
b719f91 to
0d43aab
Compare
mtojek
left a comment
There was a problem hiding this comment.
Code changes LGTM, just left questions about dependent issues.
go.mod
Outdated
| sigs.k8s.io/yaml v1.2.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/elastic/package-spec v1.3.0 => github.com/jsoriano/package-spec v0.0.0-20220112095620-98e0d531845d |
There was a problem hiding this comment.
I understand that this PR is blocked on the other one: elastic/package-spec#256?
| // SearchOptions specify the query parameters without the package name for the search API | ||
| type SearchOptions struct { | ||
| Experimental bool `url:"experimental"` | ||
| Prerelease bool `url:"prerelease"` |
There was a problem hiding this comment.
... oh, and on the EPR release.
There was a problem hiding this comment.
Yes, I think this will be the last piece to merge.
mtojek
left a comment
There was a problem hiding this comment.
Approved, but considering the order of other pull requests :)
efa3531 to
35868ba
Compare
|
Testing with integrations repo in elastic/integrations#2651 |
6c6de82 to
21b91cb
Compare
|
Added changes to implement in @mtojek could you please take another look? |
|
/test |
Stop showing information about the release tag of packages, to be deprecated in elastic/package-spec#256.
Use the
prereleaseparameter when searching for packages, related to elastic/package-registry#785.Part of elastic/package-spec#225