Conversation
It is optional now, and considered GA when not set. Semver pre-release tags should be used now to publish non-ga versions. See elastic#225
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
Mergify issue to be solved in #257. |
| @@ -1,6 +1,5 @@ | |||
| title: Nginx access logs | |||
| type: logs | |||
| release: experimental | |||
There was a problem hiding this comment.
Is the release tag is removed everywhere now, is there a way to test the "deprecation" part?
There was a problem hiding this comment.
The release tag is still present in other packages being tested, I only removed it from the "good" one.
| @@ -1,6 +1,5 @@ | |||
| title: Data stream using Kubernetes service deployer for tests | |||
| type: logs | |||
| release: experimental | |||
There was a problem hiding this comment.
I might be lost in the other email thread, but I assume we agreed on keeping the data stream release tag, right?
There was a problem hiding this comment.
Yes, I removed the deprecation (in 366c8d6), but it is still optional. I wanted to be sure that we have test cases with good packages without the tag.
|
/test |
|
@mtojek I have implemented the recent decision of limiting the allowed prerelease tags as a semantic validator, please take a look. I considered modifying the regular expression instead, but I would prefer to leave this regular expression as is to validate semver according to the spec, and our conventions are easier to maintain as a semantic validator. We can also provide better feedback to users this way. |
| type: enhancement | ||
| link: https://github.com/elastic/package-spec/pull/256 | ||
| - description: Restrict the allowed prerelease labels in sematic versions. | ||
| type: breaking-change |
What does this PR do?
Deprecate the release attribute from package manifests.
Make it optional, and considered GA when not set.
Semver pre-release tags should be used after this change to publish non-ga versions. See #225
Why is it important?
To simplify the declaration of packages in different stages, see #225.
Checklist
test/packagesthat prove my change is effective.versions/N/changelog.yml.Related issues