Fix MongoDB package for CI: address MongoDB 5.0 EOL#3288
Fix MongoDB package for CI: address MongoDB 5.0 EOL#3288teresaromero merged 5 commits intoelastic:mainfrom
Conversation
- Update Docker image and compose config for supported MongoDB version - Add deploy variants configuration - Update README documentation Co-authored-by: Cursor <cursoragent@cursor.com>
Remove creator Dockerfile and adjust docker-compose to use shared config. Co-authored-by: Cursor <cursoragent@cursor.com>
Enhance the MongoDB service in the docker-compose file by adding a healthcheck to ensure the database is running properly. This includes a command to check the server status and specifies the interval and retry settings for the healthcheck.
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
| healthcheck: | ||
| test: ["CMD", "mongosh", "--eval", "db.runCommand({serverStatus:1}).ok"] | ||
| interval: 1s | ||
| retries: 90 |
There was a problem hiding this comment.
Should this container keep using the healthcheck from the Dockerfile ? At least this is how it was set previously.
There was a problem hiding this comment.
i was confused. you are right, this secondary service does not need the mongosh specific check. i remove it an leave it only on the main service
|
buildkite test this |
Eliminate the healthcheck configuration from the MongoDB service in the docker-compose file, mongo-log on the dockerfile healthcheck
| test: ["CMD", "mongosh", "--eval", "db.runCommand({serverStatus:1}).ok"] | ||
| interval: 1s | ||
| retries: 90 | ||
| mongodb-log: |
There was a problem hiding this comment.
As this container/service is not used here in elastic-package, I think it could be removed.
This container is used in the integrations repository because it is required for the tests related to the log data stream:
But , here in the elastic-package there is just the status data stream.
mrodm
left a comment
There was a problem hiding this comment.
LGTM!
Let's merge this change to fix the tests related to this package.
If the changes in the integrations repository for this package are different, we could update this test package in a follow-up to keep both in sync.
* Revert "Fix MongoDB package for CI: address MongoDB 5.0 EOL (#3288)" This reverts commit 0f67002. * Refactor MongoDB Docker configurations to use a base image and improve health checks - Consolidated MongoDB service definitions in docker-compose.yml by introducing a base configuration. - Updated Dockerfile to utilize SERVICE_VERSION for better version management. - Enhanced health check command to ensure MongoDB service availability. - Removed the obsolete creator Dockerfile as its functionality is now integrated.
https://www.mongodb.com/legal/support-policy/lifecycles