Skip to content

[CI] Use buildkite plugin to set GitHub token#2750

Merged
mrodm merged 3 commits intoelastic:mainfrom
mrodm:use_buildkite_plugin_github_token
Jul 23, 2025
Merged

[CI] Use buildkite plugin to set GitHub token#2750
mrodm merged 3 commits intoelastic:mainfrom
mrodm:use_buildkite_plugin_github_token

Conversation

@mrodm
Copy link
Contributor

@mrodm mrodm commented Jul 21, 2025

What does this PR do?

Use https://github.com/elastic/vault-github-token-buildkite-plugin instead of using pre-command hooks with complicated conditions.
This helps to know what Buildkite step uses VAULT_GITHUB_TOKEN and self-document those sensitive details as it's a declarative syntax.

PR created after adding test integrations comment: elastic/integrations#14611

Author's checklist

  • Create integrations PR with test integrations
  • Posted the expected comments in the PR after test integrations comment.
  • Posted the expected comments in the PR after test serverless comment

Related issues

@mrodm mrodm self-assigned this Jul 21, 2025
@mrodm
Copy link
Contributor Author

mrodm commented Jul 21, 2025

test integrations

@elastic-vault-github-plugin-prod

Created or updated PR in integrations repository to test this version. Check elastic/integrations#14611

@mrodm
Copy link
Contributor Author

mrodm commented Jul 21, 2025

test serverless

@elastic-vault-github-plugin-prod

@mrodm
Copy link
Contributor Author

mrodm commented Jul 21, 2025

test serverless

@elastic-vault-github-plugin-prod

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mrodm

@mrodm mrodm marked this pull request as ready for review July 22, 2025 09:52
@mrodm mrodm requested a review from a team as a code owner July 22, 2025 09:52
@mrodm mrodm requested a review from v1v July 22, 2025 09:53
@mrodm mrodm merged commit 778b52c into elastic:main Jul 23, 2025
3 checks passed
@mrodm mrodm deleted the use_buildkite_plugin_github_token branch July 23, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants