Skip to content

Temporarily hardcode agent image reference#263

Merged
mtojek merged 2 commits intoelastic:masterfrom
mtojek:temp-fix-stack-up
Feb 24, 2021
Merged

Temporarily hardcode agent image reference#263
mtojek merged 2 commits intoelastic:masterfrom
mtojek:temp-fix-stack-up

Conversation

@mtojek
Copy link
Copy Markdown
Contributor

@mtojek mtojek commented Feb 24, 2021

This PR will temporarily hardcode the Docker image reference for Elastic Agent to the stable image. Unfortunately this fix will cause that 7.12.0-SNAPSHOT will be the only working one, but most likely will unblock development.

Related: elastic/beats#24198

@mtojek mtojek self-assigned this Feb 24, 2021
@mtojek mtojek requested a review from ycombinator February 24, 2021 14:24

elastic-agent:
image: docker.elastic.co/beats/elastic-agent:${STACK_VERSION}
image: docker.elastic.co/beats/elastic-agent@sha256:75c9fbf835a7d24166bceb82f28f4c6c5d00048ba9f0a25b945818e4cf2bba69
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a screaming comment here saying this is a temporary hack and should be removed once #261 goes green? Just in case we somehow forget about it. 😅

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added :D

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Feb 24, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #263 updated

  • Start Time: 2021-02-24T14:46:46.843+0000

  • Duration: 18 min 37 sec

  • Commit: 19f2389

Test stats 🧪

Test Results
Failed 0
Passed 292
Skipped 1
Total 293

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Copy Markdown
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mtojek mtojek merged commit fb7942f into elastic:master Feb 24, 2021
mtojek pushed a commit to mtojek/elastic-package that referenced this pull request Feb 25, 2021
mtojek added a commit that referenced this pull request Feb 25, 2021
* Bump up stack version to 7.13

* Revert "Temporarily hardcode agent image reference (#263)"

This reverts commit fb7942f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants