Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
|
I know that the CI is failing, but the code should be reviewable. |
Just curious, do you have other static assets in mind for follow up PRs? |
| } | ||
|
|
||
| func newConfig(staticTestFolderPath string) (*testConfig, error) { | ||
| configFilePath := filepath.Join(staticTestFolderPath, "config.yml") |
There was a problem hiding this comment.
Should we define this as part of the package spec, as an optional file?
There was a problem hiding this comment.
You're right, I totally forgot about the package-spec.
BTW Should I wait with this PR until you'll merge #260 or do you prefer the other way round?
There was a problem hiding this comment.
There was a problem hiding this comment.
I just merged #260 so you'll need to rebase this PR on top of master.
ycombinator
left a comment
There was a problem hiding this comment.
Left a question and a minor typo fix suggestion.
Maybe not in follow ups, but we don't have any mechanism to verify/control what's inside screenshots/icons, e.g. size, resources. |
ycombinator
left a comment
There was a problem hiding this comment.
Left a couple minor doc language cleanup suggestions. After that, LGTM.
Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
|
/test |
Fixes: #226
This PR implements static test runner with its first responsibility - linting sample events.