Updating package-spec dependency#260
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
|
CI is failing with this error: I believe this is due to recent changes in |
|
/test |
mtojek
left a comment
There was a problem hiding this comment.
The change looks good to me, but please wait for the green status.
|
Blocked by: elastic/beats#24163 |
|
@ycombinator I think it failed due to some issues around |
1c5663a to
14f0639
Compare
mtojek
left a comment
There was a problem hiding this comment.
Just a loose thought:
Personally I think that this is an overkill here (switch from JSON to YAML), because eventually we'll end up with correcting these files mostly on our own :)
IMHO you could go without deprecation period, but of course it's clearer.
Apart from this, LGTM!
Yeah, I agree about this when it comes to packages in |
This PR updates the dependency on the
package-specto bring in this change: elastic/package-spec#139.Related: elastic/package-spec#106