Skip to content

Replace deprecated apm settings#2274

Merged
jsoriano merged 3 commits intoelastic:mainfrom
jsoriano:deprecated-elasticsearch-apm-settings
Dec 16, 2024
Merged

Replace deprecated apm settings#2274
jsoriano merged 3 commits intoelastic:mainfrom
jsoriano:deprecated-elasticsearch-apm-settings

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Dec 13, 2024

tracing.apm.* settings were deprecated in 8.14.0 in favor of the new telemetry.* settings. Use the new settings starting with 8.14.0.

Old settings will be removed in 9.0.

See elastic/elasticsearch#104908.

@jsoriano
Replace deprecated apm settings
9cb13d5 
tracing.apm.* settings were deprecated in 8.14.0 in favor of the new
telemetry.* settings. Use the new settings starting with 8.14.0.

Old settings will be removed in 9.0.
@jsoriano jsoriano requested a review from a team December 13, 2024 10:06
@jsoriano jsoriano self-assigned this Dec 13, 2024
@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented Dec 13, 2024

Not sure about adding also the user setting stack.telemetry_enabled and deprecate stack.apm_enabled. I think we can continue with apm_enabled as we keep using APM for this, is only the ES settings that have changed. But not a strong opinion, both options look fine to me.

@mrodm
Copy link
Copy Markdown
Contributor

mrodm commented Dec 13, 2024

Not sure about adding also the user setting stack.telemetry_enabled and deprecate stack.apm_enabled. I think we can continue with apm_enabled as we keep using APM for this, is only the ES settings that have changed. But not a strong opinion, both options look fine to me.

With that new naming, it is true that is like agnostic of the service/implementation used, but at least, currently the stack requires APM service for this to work. So, maybe it could be kept as apm_enabled.

Just to give some other example, I remember that I required to configure APM (enabled stack.apm_enabled setting) to be able to work on a PoC where OTEL traces where sent from the elastic-package CLI in this PR: #2247

mrodm
mrodm reviewed Dec 13, 2024
View reviewed changes
internal/stack/_static/elasticsearch.yml.tmpl
Comment on lines +37 to +39
telemetry.tracing.enabled: true
telemetry.agent.server_url: "http://fleet-server:8200"
telemetry.agent.environment: "dev"
Copy link
Copy Markdown
Contributor

@mrodm mrodm Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Dec 16, 2024

💚 Build Succeeded

History

cc @jsoriano

@jsoriano jsoriano requested a review from mrodm December 16, 2024 14:03
@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented Dec 16, 2024

test integrations

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot mentioned this pull request Dec 16, 2024
Closed
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Dec 16, 2024

Created or updated PR in integrations repository to test this version. Check elastic/integrations#12116

mrodm
mrodm approved these changes Dec 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jsoriano jsoriano merged commit 70040c9 into elastic:main Dec 16, 2024
@jsoriano jsoriano deleted the deprecated-elasticsearch-apm-settings branch December 16, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrodm mrodm mrodm approved these changes

Assignees

@jsoriano jsoriano

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsoriano @mrodm @elasticmachine