Skip to content

Update package_spec#216

Closed
AaronLamb1 wants to merge 5 commits intomasterfrom
update_package_spec
Closed

Update package_spec#216
AaronLamb1 wants to merge 5 commits intomasterfrom
update_package_spec

Conversation

@AaronLamb1
Copy link
Copy Markdown

@AaronLamb1 AaronLamb1 commented Jan 11, 2021

Bringing in the most recent package spec change for unsigned_long elastic/package-spec#103

@cla-checker-service
Copy link
Copy Markdown

cla-checker-service bot commented Jan 11, 2021

💚 CLA has been signed

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Jan 11, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #216 updated

    • Start Time: 2021-01-13T14:25:52.367+0000
  • Duration: 11 min 32 sec

  • Commit: c3bcebb

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

@jonathan-buttner
Copy link
Copy Markdown
Contributor

The reason that the config.yml files had to change name is because of this PR: https://github.com/elastic/package-spec/pull/101/files#diff-b53b009efa91873f46aeec782b4cc40f8d0c9675d2ffcc1f184adae44cd72192R6

That change to the spec requires that the test files config.yml files be in the form of test-blah-config.yml. Unfortunately this means that to bring in the unsigned_long we have to bring in that change too. I believe the functionality to support multiple config.yml files is being worked on here: #209 Until that PR is merged we won't be able to update the elastic-package tool with the most recent package-spec.

image

How do we feel about pushing through this test-test-config.yml change in the interim to unblock package-spec changes?

@mtojek @ycombinator

@ycombinator
Copy link
Copy Markdown
Contributor

Each config is supposed to be for a different system test within a data stream. So maybe just call them test-default-config.yml instead of test-test-config.yml?

@mtojek mtojek self-requested a review January 12, 2021 09:18
Copy link
Copy Markdown
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AaronLamb1 Please clean up the elastic/package-spec#103 first. I noticed that you pushed lots of dependencies which IMHO wasn't necessary. Please run go mod tidy against them.

@mtojek
Copy link
Copy Markdown
Contributor

mtojek commented Jan 12, 2021

Each config is supposed to be for a different system test within a data stream. So maybe just call them test-default-config.yml instead of test-test-config.yml?

I think that @adriansr should introduce these changes first, down to Integrations. They're blocking right now.

@jonathan-buttner
Copy link
Copy Markdown
Contributor

@AaronLamb1 Please clean up the elastic/package-spec#103 first. I noticed that you pushed lots of dependencies which IMHO wasn't necessary. Please run go mod tidy against them.

@mtojek here's the PR to clean up go.mod: elastic/package-spec#104

@mtojek
Copy link
Copy Markdown
Contributor

mtojek commented Jan 13, 2021

I think that @adriansr pushed his changes, including elastic-package. @jonathan-buttner @AaronLamb1 Could you please double-check if this PR is still valid?

@jonathan-buttner
Copy link
Copy Markdown
Contributor

closing because Adrian's PR pulled in the new spec 👍

@jonathan-buttner jonathan-buttner deleted the update_package_spec branch January 13, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants