Skip to content

Cleaning up go.mod and adding command#104

Merged
jonathan-buttner merged 3 commits intoelastic:masterfrom
jonathan-buttner:tidying
Jan 12, 2021
Merged

Cleaning up go.mod and adding command#104
jonathan-buttner merged 3 commits intoelastic:masterfrom
jonathan-buttner:tidying

Conversation

@jonathan-buttner
Copy link
Copy Markdown
Contributor

Not sure why the statik.go file changed again 🤔 is it because the go.mod and go.sum files changes?

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 12, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #104 updated

  • Start Time: 2021-01-12T14:02:50.417+0000

  • Duration: 2 min 59 sec

Copy link
Copy Markdown
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... isn't it because of the changelog.yml which is included in statik.go?

@jonathan-buttner
Copy link
Copy Markdown
Contributor Author

Hm... isn't it because of the changelog.yml which is included in statik.go?

Oh yeah that could be.

type: enhancement
link: https://github.com/elastic/package-spec/pull/91
- description: Revert: Allow `condition` under inputs.
- description: 'Revert: Allow `condition` under inputs.'
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was complaining in vscode because description: Revert: is invalid yml I think.

@mtojek mtojek self-requested a review January 12, 2021 14:06
Copy link
Copy Markdown
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@jonathan-buttner jonathan-buttner merged commit 930b447 into elastic:master Jan 12, 2021
@jonathan-buttner jonathan-buttner deleted the tidying branch January 12, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants