Support validation of arrays of arrays of nested objects#1498
Merged
mrodm merged 1 commit intoelastic:mainfrom Oct 10, 2023
Merged
Support validation of arrays of arrays of nested objects#1498mrodm merged 1 commit intoelastic:mainfrom
mrodm merged 1 commit intoelastic:mainfrom
Conversation
Merged
4 tasks
Member
Author
|
Going back to draft by now in case this is not needed. |
cc5ddff to
edb4069
Compare
Member
Author
|
Closing this as the only case we had with this has been removed in elastic/integrations#8115, thanks @marc-gr! |
Collaborator
💚 Build Succeeded
cc @jsoriano |
jsoriano
added a commit
that referenced
this pull request
Sep 9, 2024
We added some additional validations for subobjects and arrays of objects in #1498, #1489 and related PRs. These validations only apply to packages with spec starting on 3.0.1. These validations rely on the structure of documents. With the adoption of features like `subobjects: false` or synthetic source the structure is lost, and exceptions based on spec version are not working, so the tests fail for cases where they should not for versions of the spec older than 3.0.1. This happens for example in the `dns` data stream of the `network_traffic` package when LogsDB is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle elastic/integrations#8115 (comment), where nested objects are stored inside an array of arrays.