Fix import of object type from ECS#1492
Merged
jsoriano merged 2 commits intoelastic:mainfrom Oct 6, 2023
Merged
Conversation
Collaborator
💚 Build Succeeded
cc @jsoriano |
19 tasks
1 task
jsoriano
added a commit
to elastic/kibana
that referenced
this pull request
Nov 6, 2023
) For `dynamic: "runtime"`, and possibly other configurations different to `dynamic: true`, intermediate objects need to exist for dynamic mappings, otherwise ingestion can fail with `Missing intermediate object` errors. This pull request includes these intermediate objects, and avoids the creation of static properties with wildcards, that is probably not what is expected for these mappings. Intermediate objects are included as static properties for parts of the name before the wildcard, and as dynamic templates when the full path has wildcards. In the modified test files are examples of all of these. This is more an issue since the following recent fixes, that create the actual dynamic mappings for some cases where only empty objects were created before. * elastic/elastic-package#1492 * #168842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not including object type in object fields can lead to ambiguous interpretations
when installing the mappings. ECS fields of type object include this information,
import it for fields when available.
Object fields must have an object type in Package Spec v3, so this change is
required to import objects from ECS without workarounds.