Skip to content

fix: external tooltip legend extra value sync#993

Merged
nickofthyme merged 2 commits intoelastic:masterfrom
nickofthyme:fix/external-event-sync
Jan 27, 2021
Merged

fix: external tooltip legend extra value sync#993
nickofthyme merged 2 commits intoelastic:masterfrom
nickofthyme:fix/external-event-sync

Conversation

@nickofthyme
Copy link
Copy Markdown
Collaborator

@nickofthyme nickofthyme commented Jan 26, 2021

Summary

fix #992

Before

Screen Recording 2021-01-26 at 01 04 PM

After

Screen Recording 2021-01-26 at 12 31 PM

Checklist

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios

@nickofthyme nickofthyme added bug Something isn't working :interactions Interactions related issue regression labels Jan 26, 2021
@nickofthyme nickofthyme requested a review from markov00 January 26, 2021 19:05
@nickofthyme nickofthyme mentioned this pull request Jan 26, 2021
Closed
monfera
monfera approved these changes Jan 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@monfera monfera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Wasn't sure why existing mocks gained legends, may not be a bad thing in general

src/chart_types/xy_chart/state/selectors/get_tooltip_values_highlighted_geoms.ts
}

if (tooltipType === TooltipType.None) {
if (tooltipType === TooltipType.None && !externalPointerEvent) {
Copy link
Copy Markdown
Contributor

@monfera monfera Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Collaborator Author

@nickofthyme nickofthyme Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love when it's just a one-line change, the hard part is knowing what line to change 🧐

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 26, 2021

Codecov Report

Merging #993 (12d685b) into master (c924310) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
+ Coverage   72.55%   72.63%   +0.07%     
==========================================
  Files         350      350              
  Lines       11052    11050       -2     
  Branches     2434     2433       -1     
==========================================
+ Hits         8019     8026       +7     
+ Misses       3019     3010       -9     
  Partials       14       14
Flag Coverage Δ
unittests 72.63% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/tooltip/tooltip.tsx 66.66% <ø> (+2.31%) ⬆️
.../selectors/get_tooltip_values_highlighted_geoms.ts 87.05% <100.00%> (ø)
src/components/portal/utils.ts 90.90% <0.00%> (+3.03%) ⬆️
src/specs/settings.tsx 90.32% <0.00%> (+3.22%) ⬆️
src/components/portal/tooltip_portal.tsx 93.15% <0.00%> (+5.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c924310...12d685b. Read the comment docs.

markov00
markov00 approved these changes Jan 27, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nickofthyme nickofthyme merged commit 13ad05a into elastic:master Jan 27, 2021
@nickofthyme nickofthyme deleted the fix/external-event-sync branch January 27, 2021 14:30
github-actions bot pushed a commit that referenced this pull request Jan 30, 2021
@semantic-release-bot
chore(release): 24.5.0 [skip ci]
d040f71 
# [24.5.0](v24.4.0...v24.5.0) (2021-01-30)

### Bug Fixes

* add theme min radius to point shape ([#996](#996)) ([eb37175](eb37175))
* align tooltip z-index to EUI tooltip z-index ([#931](#931)) ([ffd626b](ffd626b))
* chart state and series functions cleanup ([#989](#989)) ([944ac6c](944ac6c))
* create unique ids for dot icons ([#971](#971)) ([e1ce768](e1ce768))
* external tooltip legend extra value sync ([#993](#993)) ([13ad05a](13ad05a))
* **legend:** disable focus and keyboard navigation for legend in partition ch… ([#952](#952)) ([03bd2f7](03bd2f7))
* **legend:** hierarchical legend order should follow the tree paths ([#947](#947)) ([f9218ad](f9218ad)), closes [#944](#944)
* **legend:** remove ids for circles ([#973](#973)) ([b3f4f90](b3f4f90))

### Features

* **cursor:** improve theme styling for crosshair ([#980](#980)) ([6c4dafd](6c4dafd))
* **legend:**  display pie chart legend extra ([#939](#939)) ([d14de01](d14de01))
* **legend:** add keyboard navigation ([#880](#880)) ([87c227d](87c227d))
* **partition:** Flame and icicle chart ([#965](#965)) ([3df73d0](3df73d0))
* **partition:** legend hover options ([#978](#978)) ([f810d94](f810d94))
* **xy:** support multiple point shapes on line, area and bubble charts ([#988](#988)) ([1392b7d](1392b7d))
@markov00
Copy link
Copy Markdown
Collaborator

markov00 commented Jan 30, 2021

🎉 This PR is included in version 24.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jan 30, 2021
@nickofthyme nickofthyme mentioned this pull request Feb 1, 2021
Merged
nickofthyme added a commit to nickofthyme/elastic-charts that referenced this pull request Feb 1, 2021
@nickofthyme
fix: external tooltip legend extra value sync (elastic#993)
7484a3e
@nickofthyme nickofthyme mentioned this pull request Feb 2, 2021
Merged
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 24.5.0 [skip ci]
b3d1a20 
# [24.5.0](elastic/elastic-charts@v24.4.0...v24.5.0) (2021-01-30)

### Bug Fixes

* add theme min radius to point shape ([opensearch-project#996](elastic/elastic-charts#996)) ([98089a9](elastic/elastic-charts@98089a9))
* align tooltip z-index to EUI tooltip z-index ([opensearch-project#931](elastic/elastic-charts#931)) ([f7f1f6f](elastic/elastic-charts@f7f1f6f))
* chart state and series functions cleanup ([opensearch-project#989](elastic/elastic-charts#989)) ([42a7af0](elastic/elastic-charts@42a7af0))
* create unique ids for dot icons ([opensearch-project#971](elastic/elastic-charts#971)) ([0b3e00f](elastic/elastic-charts@0b3e00f))
* external tooltip legend extra value sync ([opensearch-project#993](elastic/elastic-charts#993)) ([7e1096e](elastic/elastic-charts@7e1096e))
* **legend:** disable focus and keyboard navigation for legend in partition ch… ([opensearch-project#952](elastic/elastic-charts#952)) ([dfff3e2](elastic/elastic-charts@dfff3e2))
* **legend:** hierarchical legend order should follow the tree paths ([opensearch-project#947](elastic/elastic-charts#947)) ([7b70186](elastic/elastic-charts@7b70186)), closes [opensearch-project#944](elastic/elastic-charts#944)
* **legend:** remove ids for circles ([opensearch-project#973](elastic/elastic-charts#973)) ([ed98481](elastic/elastic-charts@ed98481))

### Features

* **cursor:** improve theme styling for crosshair ([opensearch-project#980](elastic/elastic-charts#980)) ([0248ad6](elastic/elastic-charts@0248ad6))
* **legend:**  display pie chart legend extra ([opensearch-project#939](elastic/elastic-charts#939)) ([672a4df](elastic/elastic-charts@672a4df))
* **legend:** add keyboard navigation ([opensearch-project#880](elastic/elastic-charts#880)) ([b471a94](elastic/elastic-charts@b471a94))
* **partition:** Flame and icicle chart ([opensearch-project#965](elastic/elastic-charts#965)) ([9e8b1f7](elastic/elastic-charts@9e8b1f7))
* **partition:** legend hover options ([opensearch-project#978](elastic/elastic-charts#978)) ([acd1339](elastic/elastic-charts@acd1339))
* **xy:** support multiple point shapes on line, area and bubble charts ([opensearch-project#988](elastic/elastic-charts#988)) ([4f23b4f](elastic/elastic-charts@4f23b4f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markov00 markov00 markov00 approved these changes

+1 more reviewer

@monfera monfera monfera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working :interactions Interactions related issue regression released Issue released publicly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

External cursor doesn't sync legend values

4 participants

@nickofthyme @codecov-io @markov00 @monfera