feat(domain): scale data to a specific domain via axis spec#98
Merged
emmacunningham merged 24 commits intoelastic:masterfrom Mar 19, 2019
Merged
feat(domain): scale data to a specific domain via axis spec#98emmacunningham merged 24 commits intoelastic:masterfrom
emmacunningham merged 24 commits intoelastic:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 88.63% 88.86% +0.22%
==========================================
Files 28 28
Lines 1144 1167 +23
Branches 118 119 +1
==========================================
+ Hits 1014 1037 +23
+ Misses 120 119 -1
- Partials 10 11 +1
Continue to review full report at Codecov.
|
emmacunningham
commented
Mar 18, 2019
emmacunningham
commented
Mar 18, 2019
markov00
reviewed
Mar 19, 2019
Collaborator
markov00
left a comment
There was a problem hiding this comment.
Code LGTM, tested locally.
I've left few minor comments on code.
markov00
approved these changes
Mar 19, 2019
Collaborator
markov00
left a comment
There was a problem hiding this comment.
Changes after review LGTM.
markov00
pushed a commit
that referenced
this pull request
Mar 19, 2019
# [3.2.0](v3.1.1...v3.2.0) (2019-03-19) ### Features * **domain:** scale data to a specific domain via axis spec ([#98](#98)) ([b039ebf](b039ebf))
Collaborator
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
19 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [3.2.0](elastic/elastic-charts@v3.1.1...v3.2.0) (2019-03-19) ### Features * **domain:** scale data to a specific domain via axis spec ([opensearch-project#98](elastic/elastic-charts#98)) ([4857e42](elastic/elastic-charts@4857e42))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close #86
This PR introduces the feature to specify custom domains for a series. There are two types of domains to customize: xDomain and yDomains.
xDomain
xDomain is configured via the
Settingsspec because the xDomain is shared globally and so the user should only be able to configure one xDomain.yDomains
yDomains are configured per axis/group.
If a domain is supplied for an axis that is an xDomain axis, an error will be thrown, letting the user know that this should be added through the Settings spec.
If a user specifies multiple domains for the same group (which can be done when having multiple axes), then the domains are merged to cover the largest range of the supplied domains (e.g. if
{ min: 0, max: 5 }and{ min: 1, max: 15 }are provided as the domains for the same group, then the merged domain applied would be{ min : 0, max: 15 })Also, to allow the user to specify a custom domain but not show the axis, we implement the
hidefeature.Custom domain w/ hidden axis:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.