fix(heatmap): destroy canvas bbox calculator when done#844
Merged
markov00 merged 3 commits intoelastic:masterfrom Oct 5, 2020
Merged
fix(heatmap): destroy canvas bbox calculator when done#844markov00 merged 3 commits intoelastic:masterfrom
markov00 merged 3 commits intoelastic:masterfrom
Conversation
nickofthyme
approved these changes
Oct 5, 2020
markov00
pushed a commit
that referenced
this pull request
Oct 6, 2020
# [23.2.0](v23.1.1...v23.2.0) (2020-10-06) ### Bug Fixes * **heatmap:** adjust pageSize based available chart height ([#849](#849)) ([9aa396b](9aa396b)) * **heatmap:** destroy canvas bbox calculator when done ([#844](#844)) ([42460bd](42460bd)) * **heatmap:** x-axis labels overlapping for time series data ([#850](#850)) ([9ebd879](9ebd879)) * **interactions:** recognise drag after 100ms and 4px ([#848](#848)) ([70626fe](70626fe)), closes [#748](#748) ### Features * heatmap tooltip enhancements and fixes ([#847](#847)) ([d879e05](d879e05))
Collaborator
Author
|
🎉 This PR is included in version 23.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [23.2.0](elastic/elastic-charts@v23.1.1...v23.2.0) (2020-10-06) ### Bug Fixes * **heatmap:** adjust pageSize based available chart height ([opensearch-project#849](elastic/elastic-charts#849)) ([fd56099](elastic/elastic-charts@fd56099)) * **heatmap:** destroy canvas bbox calculator when done ([opensearch-project#844](elastic/elastic-charts#844)) ([4c1fd55](elastic/elastic-charts@4c1fd55)) * **heatmap:** x-axis labels overlapping for time series data ([opensearch-project#850](elastic/elastic-charts#850)) ([7cbd151](elastic/elastic-charts@7cbd151)) * **interactions:** recognise drag after 100ms and 4px ([opensearch-project#848](elastic/elastic-charts#848)) ([f7aa7f8](elastic/elastic-charts@f7aa7f8)), closes [opensearch-project#748](elastic/elastic-charts#748) ### Features * heatmap tooltip enhancements and fixes ([opensearch-project#847](elastic/elastic-charts#847)) ([6d763fb](elastic/elastic-charts@6d763fb))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The heatmap use the CanvasBBoxCalculator to compute the right size for labels. The calculator wasn't destroyed after the completion of the task and caused the used
canvaselement to remain in the dom.This fix destroy the
canvasused after the measurement task is completed