Skip to content

feat(series): add simple mark formatter#775

Merged
nickofthyme merged 5 commits intoelastic:masterfrom
nickofthyme:mark-formatter
Sep 14, 2020
Merged

feat(series): add simple mark formatter#775
nickofthyme merged 5 commits intoelastic:masterfrom
nickofthyme:mark-formatter

Conversation

@nickofthyme
Copy link
Copy Markdown
Collaborator

@nickofthyme nickofthyme commented Jul 31, 2020 •
edited
Loading

Summary

Add simple way to format mark accessor values before tooltip redesign (#615)

Screen Recording 2020-09-10 at 01 11 PM

Checklist

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility, including a check against IE11
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios

@nickofthyme nickofthyme added :data Data/series/scales related issue :tooltip Related to hover tooltip :xy Bar/Line/Area chart related labels Jul 31, 2020
@nickofthyme nickofthyme requested a review from markov00 July 31, 2020 04:43
@markov00 markov00 mentioned this pull request Jul 31, 2020
Closed
27 tasks
@nickofthyme nickofthyme marked this pull request as ready for review September 10, 2020 18:12
@nickofthyme nickofthyme requested a review from monfera September 10, 2020 18:55
monfera
monfera reviewed Sep 10, 2020
View reviewed changes
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 12, 2020

Codecov Report

Merging #775 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
+ Coverage   74.48%   74.52%   +0.03%     
==========================================
  Files         267      288      +21     
  Lines        9152     9640     +488     
  Branches     1883     2061     +178     
==========================================
+ Hits         6817     7184     +367     
- Misses       2330     2443     +113     
- Partials        5       13       +8
Flag Coverage Δ
#unittests 74.00% <ø> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/chart_types/xy_chart/utils/series.ts 87.05% <0.00%> (-10.24%) ⬇️
...chart_types/xy_chart/utils/stacked_series_utils.ts 88.05% <0.00%> (-9.93%) ⬇️
src/utils/accessor.ts 81.81% <0.00%> (-8.19%) ⬇️
..._chart/state/selectors/compute_chart_dimensions.ts 92.00% <0.00%> (-8.00%) ⬇️
src/components/tooltip/tooltip.tsx 64.00% <0.00%> (-6.33%) ⬇️
src/utils/commons.ts 90.20% <0.00%> (-3.73%) ⬇️
src/chart_types/xy_chart/renderer/canvas/grids.ts 40.74% <0.00%> (-3.26%) ⬇️
src/chart_types/xy_chart/rendering/rendering.ts 93.28% <0.00%> (-1.52%) ⬇️
src/chart_types/xy_chart/utils/axis_utils.ts 92.44% <0.00%> (-1.45%) ⬇️
...t_types/partition_chart/state/selectors/tooltip.ts 29.16% <0.00%> (-1.27%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2758b...54c89e4. Read the comment docs.

@nickofthyme nickofthyme requested a review from monfera September 14, 2020 13:49
monfera
monfera approved these changes Sep 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@monfera monfera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Nick, thanks!

@nickofthyme nickofthyme merged commit ab95284 into elastic:master Sep 14, 2020
@nickofthyme nickofthyme deleted the mark-formatter branch September 14, 2020 14:13
markov00 pushed a commit that referenced this pull request Sep 14, 2020
@semantic-release-bot
chore(release): 21.2.0 [skip ci]
c7bb4eb 
# [21.2.0](v21.1.2...v21.2.0) (2020-09-14)

### Features

* blind sorting option for vislib ([#813](#813)) ([8afce43](8afce43))
* order ordinal values by sum ([#814](#814)) ([5b2758b](5b2758b))
* **series:** add simple mark formatter ([#775](#775)) ([ab95284](ab95284))
@markov00
Copy link
Copy Markdown
Collaborator

markov00 commented Sep 14, 2020

🎉 This PR is included in version 21.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Sep 14, 2020
@nickofthyme nickofthyme mentioned this pull request Oct 1, 2020
Merged
1 task
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 21.2.0 [skip ci]
ade8d8b 
# [21.2.0](elastic/elastic-charts@v21.1.2...v21.2.0) (2020-09-14)

### Features

* blind sorting option for vislib ([opensearch-project#813](elastic/elastic-charts#813)) ([79d0e4f](elastic/elastic-charts@79d0e4f))
* order ordinal values by sum ([opensearch-project#814](elastic/elastic-charts#814)) ([45ea0c6](elastic/elastic-charts@45ea0c6))
* **series:** add simple mark formatter ([opensearch-project#775](elastic/elastic-charts#775)) ([75bd8d5](elastic/elastic-charts@75bd8d5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markov00 markov00 Awaiting requested review from markov00

1 more reviewer

@monfera monfera monfera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:data Data/series/scales related issue released Issue released publicly :tooltip Related to hover tooltip :xy Bar/Line/Area chart related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nickofthyme @codecov-commenter @markov00 @monfera